Update fast-glob references #11660
Replies: 2 comments
-
Thanks, Armand! Certainly, we do suggest that some kind of ordering is done when using I also think the "read more" link swap you propose looks good! I think these could be two separate docs issues, and each of them labelled as |
Beta Was this translation helpful? Give feedback.
-
Indeed, we had some explanation regarding the order! I just found where it was... in the v5 upgrade guide, so we should repeat that information in the content collections guide because not everyone is upgrading. 😄 #11673 and #11674 have been opened, so we can close this discussion! |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Since withastro/astro#13299, Astro no longer uses
fast-glob
buttinyglobby
. Referring to a Discord issue, it seems there is a difference at least in the output order. So we might encounter issues with glob patterns too...We still have links to
fast-glob
in:guides/imports.mdx
upgrade-to/v5
The second link is not an issue I think. However, the first one is in a section named
Glob Patterns in Astro
so this could be confusing since glob patterns in Astro no longer rely onfast-glob
(and neither Vite'simport.meta.glob
).The issue is...
fast-glob
docs is a bit more detailed thantinyglobby
docs so there is no equivalent link. From my understanding,fast-glob
usesmicromatch
under the hood whiletinyglobby
usespicomatch
.So, does the read more link could be replaced
In my opinion, this could work but maybe I'm missing something.
This is a small issue... I could have make a PR but I'm not sure I'm not missing something here so a discussion felt more appropriate!
Edit: related to the Discord issue, explaining that users should order themselves the output of
getCollection
to have confidence on the output order could be helpful I think. Maybe in Querying collections.Beta Was this translation helpful? Give feedback.
All reactions