-
-
Notifications
You must be signed in to change notification settings - Fork 19
Copy Translations #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy Translations #99
Conversation
attributes, there is an example of doing it but it's not clear and easy to miss
|
Very nice, It's very easy to use and works very fast. |
IDEACurrently, switching languages at once works well while holding down CTRL. In this stage, since it is not auto translated, copying fields is perhaps not ideal (except for repeaters). |
IDEAOn a sidenote, we add the same image for each language for SEO purposes.
When copying an image field to another language, it would be great, in our case, to:
|
FIXED
For me it doesn't really matter, but what if you do not want this functionality? Should this be a seperate plugin extending Winter.Translate? |
|
@AIC-BV Looks like the padding issue in the textarea is pretty straightforward, and the spacing on the mediafinder. So I will go ahead and just make those adjustments. @LukeTowers I know you are on vacation, but when you get back, I am happy to discuss some of the other feature requests, the accidentally copying thing, is I think a decent quality of life improvement. Because you do run the risk of writing a bunch of stuff without saving, then accidentally copying, and now you have to refresh the page, loosing all your progress. Maybe a simple warning pop-up: "Are you sure you want to copy?" |
styles. Stylistically I chose to the use the smaller buttons for the media finder and the editors because they would overlap with the content otherwise.
|
@AIC-BV I fixed the overlap and the wrong dropdown positioning, do you wanna have another try at this branch see if it's working as expected? :) |
But the overlap is still there? |
Ohh I am sorry I see what you mean, I was thinking you were just talking about the rich editor as per your previous screenshot, so thats what I changed, did you try that? The text area doesn't show the translate stuff when you are typing in it right, so I figured that was ok to leave the same. @LukeTowers what do you think? We could use the same button styling that is on the repeater and the editors on the textarea? |
I see what you did there. @mjauvin what do you think about moving the buttons to the top to avoid overlap with the text? |
|
@mjauvin could you elaborate on that? What are your objections to having it enabled always and / or by default? |
In my opinion, if the functionality is not going to be used for specific people, it will clutter the UI more than it already does. I don't really mind if it's on by default (as long as it can easily be changed programatically), but I really want this as an optional feature. |
RESEARCHMy Logitech mouse has some software that opens on one of the button clicks and looks like this ANSWER TO YOUR QUESTIONSo if this answers your question; a simple suggestion of how it could look like for a Field to Field translation is this;
If translating an entire model at once is easy/easier/better
This is just an idea of how I imagined it, feel free to share your ideas LIVE EXAMPLEAn example of a ChatGPT translated grouped repeater (block per block) without any spelling/content check (I just pasted the result without checking it to get started quickly): https://www.maatkastenonline.be/en/our-closets/laundry-closet This costed me 45 minuts to manually find out the prompt (which probably took around 25-30 minuts) and send it block per block to ChatGPT. I imagine if you do this manually, with rebuilding the grouped repeater content, it would take atleast 5-hours of boring monkey labor. I am no English expert but I think this demonstrates the power of auto-translating and I cannot imagine this not to be a popular translation extension. IDEASo maybe it needs a:
All three prompt fields will be merged in to a single prompt + the content that is selected for translation. It is up to the user to define the right prompts for the right answer. |
|
@LukeTowers Can you still see the forest through the trees? 😅 |
|
@IsaiahPaget using this PR in version 2.3.1, the placement for the language selector / copyfrom button is all over the place... what am I missing? Also, there should have been an entry added to the config to show how to disable the copyfrom... I see it in the code, but no mention in the config file. |
|
Somehow, I had to force my browser to clear its cache to get the new multilingual CSS... not sure why as the All working fine now. |
|
Ok, brain cramp: forgot to run artisan migrate... all good, sorry for the noise! |











Added the ability to 'copy from' one language to another, this will aid users workflow because they will be able to see the structure of what they wrote in one language and make tweaks to it inline rather than manually copying or maybe even trying to remember what they wrote.
The original issue(90) was just about the repeater, but this PR includes this functionality for every ML formwidget.
I also updated the readme for some clearer examples of accessing json attributes on models.