-
Notifications
You must be signed in to change notification settings - Fork 70
Open
Labels
A-combinatorArea: combinatorsArea: combinatorsC-bugCategory: Things not working as expectedCategory: Things not working as expectedM-breaking-changeMeta: Implementing or merging this will introduce a breaking change.Meta: Implementing or merging this will introduce a breaking change.
Milestone
Description
separated_foldl1
and separated_foldr1
accept impl FnMut(O, S, O) -> O
and return a Result<O>
Iterator::fold
accepts (R, impl FnMut(R, O) -> R)
and returns an R
.
Iterator::reduce
accepts FnMut(O, O) -> O
and returns an Option<O>
.
The parameters better match what Iterator::reduce
accept and switching fold
for reduce
would better align on terminology, making it easier for users to pick up winnow through consistency.
The downside is that the trailing letter looks more odd in this situation. That convention was picked up from chumskey and we may want to consider an alternative
Metadata
Metadata
Assignees
Labels
A-combinatorArea: combinatorsArea: combinatorsC-bugCategory: Things not working as expectedCategory: Things not working as expectedM-breaking-changeMeta: Implementing or merging this will introduce a breaking change.Meta: Implementing or merging this will introduce a breaking change.