FasterXML#220 use StringBuilder instead of StringBuffer (+ some cleanup)

Author: winfriedgerlach

src/main/java/com/ctc/wstx/dtd/DTDId.java

@@ -111,7 +111,7 @@ public int hashCode() {
 
     @Override
     public String toString() {
-        StringBuffer sb = new StringBuffer(60);
+        StringBuilder sb = new StringBuilder(60);
         sb.append("Public-id: ");
         sb.append(mPublicId);
         sb.append(", system-id: ");

src/main/java/com/ctc/wstx/evt/WstxEventReader.java

@@ -220,7 +220,7 @@ public String getElementText() throws XMLStreamException
         // ??? do we need to update mPrePeekEvent now
 
         String str = null;
-        StringBuffer sb = null;
+        StringBuilder sb = null;
 
         // Ok, fine, then just need to loop through and get all the text...
         for (; true; evt = nextEvent()) {
@@ -240,7 +240,7 @@ public String getElementText() throws XMLStreamException
                 str = curr;
             } else {
                 if (sb == null) {
-                    sb = new StringBuffer(str.length() + curr.length());
+                    sb = new StringBuilder(str.length() + curr.length());
                     sb.append(str);
                 }
                 sb.append(curr);

src/main/java/com/ctc/wstx/sr/StreamScanner.java

@@ -1120,9 +1120,9 @@ protected void throwNullParent(WstxInputSource curr)
      * <ol>
      *  <li>Entity in question is a simple character entity (either one of
      *    5 pre-defined ones, or using decimal/hex notation), AND
-     *   <li>
+     *   </li>
      *  <li>Entity fits completely inside current input buffer.
-     *   <li>
+     *   </li>
      * </ol>
      * If so, character value of entity is returned. Character 0 is returned
      * otherwise; if so, caller needs to do full resolution.

src/test/java/org/codehaus/stax/test/stream/TestGetSegmentedText.java

@@ -196,7 +196,7 @@ private void doTest(boolean ns, boolean coalescing, boolean autoEntity)
                     // Sanity check #2: and string buf should have it too
                     assertEquals
                         ("Expected segment #"+segOffset+" (one-based; read with "+readCount+" reads) to get "
-                         +expLen+" chars; StringBuffer only has "+sb.length(),
+                         +expLen+" chars; StringBuilder only has "+sb.length(),
                          expLen, sb.length());
 
                     totalBuf.append(sb);

src/test/java/stax2/BaseStax2Test.java

@@ -14,8 +14,6 @@
 import org.codehaus.stax2.evt.*;
 
 import org.codehaus.stax2.ri.Stax2ReaderAdapter;
-import org.codehaus.stax2.validation.ValidationProblemHandler;
-import org.codehaus.stax2.validation.XMLValidationException;
 import org.codehaus.stax2.validation.XMLValidationProblem;
 import org.codehaus.stax2.validation.XMLValidationSchema;
 

src/test/java/wstxtest/io/TestUTF8Reader.java

@@ -1,6 +1,7 @@
 package wstxtest.io;
 
 import java.io.*;
+import java.util.Arrays;
 
 import junit.framework.TestCase;
 
@@ -26,9 +27,7 @@ public void testDelAtBufferBoundary() throws IOException
 
 	// Create input that will cause the array index out of bounds exception
 	byte[] inputBytes = new byte[INPUT_SIZE];
-	for (int i=0; i < inputBytes.length; i++) {
-	    inputBytes[i] = CHAR_FILLER;
-	}
+	Arrays.fill(inputBytes, CHAR_FILLER);
 	inputBytes[BYTE_BUFFER_SIZE - 1] = CHAR_DEL;
 	InputStream in = new ByteArrayInputStream(inputBytes);