The 'dump' command generates files in web/js/ by default

Fix #84

Author: willdurand

Command/DumpCommand.php

@@ -40,7 +40,7 @@ protected function initialize(InputInterface $input, OutputInterface $output)
         parent::initialize($input, $output);
 
         $this->targetPath = $input->getArgument('target') ?:
-            realpath(sprintf('%s/../web/', $this->getContainer()->getParameter('kernel.root_dir')));
+            realpath(sprintf('%s/../web/js', $this->getContainer()->getParameter('kernel.root_dir')));
     }
 
     /**

Dumper/TranslationDumper.php

@@ -89,7 +89,7 @@ public function addLoader($id, $loader)
      *
      * @param string $target Target directory.
      */
-    public function dump($target = 'web')
+    public function dump($target = 'web/js')
     {
         $route         = $this->router->getRouteCollection()->get('bazinga_jstranslation_js');
         $requirements  = $route->getRequirements();
@@ -108,10 +108,13 @@ public function dump($target = 'web')
     private function dumpConfig($route, array $formats, $target)
     {
         foreach ($formats as $format) {
-            $file = sprintf('%s/%s', $target, strtr($route->getPattern(), array(
-                '{domain}'  => 'config',
-                '{_format}' => $format
-            )));
+            $file = sprintf('%s/%s',
+                $target,
+                strtr($route->getPattern(), array(
+                    '{domain}'  => 'config',
+                    '{_format}' => $format
+                ))
+            );
 
             $this->filesystem->mkdir(dirname($file), 0755);
 
@@ -144,7 +147,7 @@ private function dumpTranslations($route, array $formats, $target)
                     $file = sprintf('%s/%s',
                         $target,
                         strtr($route->getPattern(), array(
-                            '{domain}'  => $domain . '/' . $locale,
+                            '{domain}'  => sprintf('%s/%s', $domain, $locale),
                             '{_format}' => $format
                         ))
                     );

Resources/doc/index.md

@@ -130,7 +130,8 @@ This bundle provides a command to dump the translation files:
     php app/console bazinga:js-translation:dump [target]
 
 The optional `target` argument allows you to override the target directory to
-dump JS translation files in.
+dump JS translation files in. By default, it generates files in the `web/js/`
+directory.
 
 You have to load a `config.js` file, which contains the configuration for the
 JS Translator, then you can load all translation files that have been dumped.
@@ -145,14 +146,14 @@ The command above is useful if you use
 ```twig
 {% javascripts
     'bundles/bazingajstranslation/js/translator.min.js'
-    'translations/config.js'
-    'translations/*/*.js' %}
+    'js/translations/config.js'
+    'js/translations/*/*.js' %}
     <script src="{{ asset_url }}"></script>
 {% endjavascripts %}
 ```
 
 In the example above, all translation files from your entire project will be
-loaded. Of course you can load specific domains: `translations/admin/*.js`.
+loaded. Of course you can load specific domains: `js/translations/admin/*.js`.
 
 ### The JS Translator
 

Tests/Dumper/TranslationDumperTest.php

@@ -20,7 +20,7 @@ public function setUp()
         $client    = static::createClient();
         $container = $client->getContainer();
 
-        $this->target     = sys_get_temp_dir() . '/bazinga/js-translation-bundle/';
+        $this->target     = sys_get_temp_dir() . '/bazinga/js-translation-bundle';
         $this->filesystem = $container->get('filesystem');
         $this->dumper     = $container->get('bazinga.jstranslation.translation_dumper');