Skip to content

Proxy detection mechanism only recognises uppercase environment variables #78

@ghost

Description

Hello!

Current implementation as in WebSocket._detect_proxies class method will only detect uppercase proxy server environment variables. This is sub-optimal, since majority of software respects lowercase http_proxy and https_proxy environment variables.

Luckily case insensitive functionality is already available in Python's standard library, specifically in urllib.request.getproxies https://docs.python.org/3/library/urllib.request.html?highlight=getproxies#urllib.request.getproxies.

Please, consider using urllib.request.getproxies() for proxy detection instead of custom solution!
Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions