emacs-mcx.cursorMoveOnFindWidget is not good enough

[zero00072]

From #1607, yes, the emacs-mcx.cursorMoveOnFindWidget solved it.

But not good enough.

When I C-s to search, and now I typed C-n. Ohhhh, it's open a new tab. I just want to go to next line. What happend?

The things happend on other keys like C-p (Move to file), C-b (close left pane).

I think the good way is just disable arrow keys (LEFT & RIGHT), HOME and END at search. Not others, do as plain Emacs.

[
  {
    "key": "right",
    "command": "-emacs-mcx.isearchExit",
    "when": "editorFocus && findWidgetVisible && !config.emacs-mcx.cursorMoveOnFindWidget && !isComposing && !replaceInputFocussed"
  },
  {
    "key": "left",
    "command": "-emacs-mcx.isearchExit",
    "when": "editorFocus && findWidgetVisible && !config.emacs-mcx.cursorMoveOnFindWidget && !isComposing && !replaceInputFocussed"
  },
  {
    "key": "home",
    "command": "-emacs-mcx.isearchExit",
    "when": "editorFocus && findWidgetVisible && !config.emacs-mcx.cursorMoveOnFindWidget && !isComposing && !replaceInputFocussed"
  },
  {
    "key": "end",
    "command": "-emacs-mcx.isearchExit",
    "when": "editorFocus && findWidgetVisible && !config.emacs-mcx.cursorMoveOnFindWidget && !isComposing && !replaceInputFocussed"
  }
]

[whitphx]

What environment are you using VSCode in? Linux?

Probably the problem you mentioned was discussed in #55 that the Emacs-like key operations such as C-n or C-p on the find widget triggers unexpected commands natively bound to these keys when emacs-mcx.cursorMoveOnFindWidget is enabled, and fixed in https://github.com/whitphx/vscode-emacs-mcx/pull/755/files#diff-9b7b0b67718c474ea5397b8b075728e43b520cbb41bb6443d89f63d4e199e6eaR304-R335 for Windows, in which C-n and C-p doesn't work as Emacs-like unlike macOS.
Should we turn on this workaround in Linux as well, while these keys will be no-op instead of exiting isearch?

[zero00072]

Hi! Thanks to the author of this magic.

Yes, I am using Linux. Oh, so it is only happend on Linux? OK.

Give them no-op is a good idea. I pro this recommend.

This issue is just mention there exist strangeness.