Skip to content

Commit 4c39c5a

Browse files
committed
Fixed Google Analytics cookie name. Closes #8
1 parent e96ba1d commit 4c39c5a

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

resources/lang/en/cookies.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
'session' => 'Used to identify the user\'s browsing session.',
3535
'csrf' => 'Used to secure both the user and our website against cross-site request forgery attacks.',
3636
'_ga' => 'Main cookie used by Google Analytics, enables a service to distinguish one visitor from another.',
37-
'_ga_ID' => 'Used by Google Analytics.',
37+
'_ga_ID' => 'Used by Google Analytics to persist session state.',
3838
'_gid' => 'Used by Google Analytics to identify the user.',
3939
'_gat' => 'Used by Google Analytics to throttle the request rate.',
4040
],

resources/lang/fr/cookies.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
'session' => 'Identification de la session de navigation de l\'utilisateur.',
3535
'csrf' => 'Protection de l\'utilisateur et notre site contre les attaques d\'usurpation d\'identité lors des requêtes.',
3636
'_ga' => 'Cookie principal utilisé par Google Analytics, permettant de distinguer un visiteur d\'un autre.',
37-
'_ga_ID' => 'Utilisé par Google Analytics.',
37+
'_ga_ID' => 'Utilisé par Google Analytics pour conserver l\'état de la session.',
3838
'_gid' => 'Utilisé par Google Analytics pour identifier un visiteur.',
3939
'_gat' => 'Utilisé par Google Analytics pour limiter le taux de demande.',
4040
],

resources/lang/nl/cookies.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
'session' => 'Identificatie van de browsersessie van de gebruiker.',
3535
'csrf' => 'Beschermen van de gebruiker en onze site tegen imitatie-aanvallen tijdens server interacties.',
3636
'_ga' => 'Hoofdcookie gebruikt door Google Analytics, waarmee de ene bezoeker van de andere kan worden onderscheiden.',
37-
'_ga_ID' => 'Gebruikt door Google Analytics.',
37+
'_ga_ID' => 'Gebruikt door Google Analytics om de sessiestatus te behouden.',
3838
'_gid' => 'Gebruikt door Google Analytics om een gebruiker te identificeren.',
3939
'_gat' => 'Gebruikt door Google Analytics om de aanvraag hoeveelheid te handhaven.',
4040
],

src/AnalyticCookiesCategory.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,10 @@ class AnalyticCookiesCategory extends CookiesCategory
1212
public function google(string $id): static
1313
{
1414
$this->group(function(CookiesGroup $group) use ($id) {
15+
$key = (strpos($id, 'G-') === 0) ? substr($id, 2) : $id;
1516
$group->name(static::GOOGLE_ANALYTICS)
1617
->cookie(fn(Cookie $cookie) => $cookie->name('_ga')->duration(2 * 365 * 24 * 60)->description(__('cookieConsent::cookies.defaults._ga')))
17-
->cookie(fn(Cookie $cookie) => $cookie->name('_ga_' . strtoupper($id))->duration(2 * 365 * 24 * 60)->description(__('cookieConsent::cookies.defaults._ga_ID')))
18+
->cookie(fn(Cookie $cookie) => $cookie->name('_ga_'.strtoupper($key))->duration(2 * 365 * 24 * 60)->description(__('cookieConsent::cookies.defaults._ga_ID')))
1819
->cookie(fn(Cookie $cookie) => $cookie->name('_gid')->duration(26 * 60)->description(__('cookieConsent::cookies.defaults._gid')))
1920
->cookie(fn(Cookie $cookie) => $cookie->name('_gat')->duration(1)->description(__('cookieConsent::cookies.defaults._gat')))
2021
->accepted(function(Consent $consent) use ($id) {

0 commit comments

Comments
 (0)