From 6b91cd9c39b392f5efd3ca7f80147ae0c16d4690 Mon Sep 17 00:00:00 2001 From: Andrew Rubin Date: Tue, 6 May 2025 08:58:24 -0700 Subject: [PATCH] fix(InView utils): remove subdivisions argument from get-duration --- .changeset/forty-boats-battle.md | 5 +++++ .../in-view-item/styles/_in-view-utilities.scss | 4 ++-- .../in-view-item/styles/in-view-item.module.scss | 10 +++++----- 3 files changed, 12 insertions(+), 7 deletions(-) create mode 100644 .changeset/forty-boats-battle.md diff --git a/.changeset/forty-boats-battle.md b/.changeset/forty-boats-battle.md new file mode 100644 index 00000000..1b0c9cc0 --- /dev/null +++ b/.changeset/forty-boats-battle.md @@ -0,0 +1,5 @@ +--- +"@wethegit/components": patch +--- + +Fixes an issue with the InViewItem component, where the delays were being caluculated incorrectly. For example, using a delay value of `8` would return a `0.4s` value instead of a `0.8s` value. diff --git a/packages/wethegit-components/src/components/in-view/components/in-view-item/styles/_in-view-utilities.scss b/packages/wethegit-components/src/components/in-view/components/in-view-item/styles/_in-view-utilities.scss index 3f180ff2..3ec9b655 100644 --- a/packages/wethegit-components/src/components/in-view/components/in-view-item/styles/_in-view-utilities.scss +++ b/packages/wethegit-components/src/components/in-view/components/in-view-item/styles/_in-view-utilities.scss @@ -4,8 +4,8 @@ * Returns a value in seconds, equal to the number passed divided by 10. (2 => 0.2s) * Useful when generating duration or delay classnames. */ -@function get-duration($i, $subDivisions: 10) { - @return calc(#{$i} / #{$subDivisions} * 1s * var(--duration-factor, 1)); +@function get-duration($i) { + @return calc(#{$i} / 10s * var(--duration-factor, 1)); } /** diff --git a/packages/wethegit-components/src/components/in-view/components/in-view-item/styles/in-view-item.module.scss b/packages/wethegit-components/src/components/in-view/components/in-view-item/styles/in-view-item.module.scss index 0ba76498..1da29c57 100644 --- a/packages/wethegit-components/src/components/in-view/components/in-view-item/styles/in-view-item.module.scss +++ b/packages/wethegit-components/src/components/in-view/components/in-view-item/styles/in-view-item.module.scss @@ -38,15 +38,15 @@ // Example: `.delay2` is a 0.2s delay. @for $i from 0 through 10 { .delay#{$i} { - --delay: #{get-duration($i, 10)}; + --delay: #{get-duration($i)}; } .staggerAmount#{$i} { - --stagger-amount: #{get-duration($i, 10)}; + --stagger-amount: #{get-duration($i)}; } .staggerDelay#{$i} { - --stagger-delay: #{get-duration($i, 10)}; + --stagger-delay: #{get-duration($i)}; } } @@ -55,10 +55,10 @@ // Example: `.duration15` is a 1.5s duration. @for $i from 0 through 20 { .duration#{$i} { - --duration: #{get-duration($i, 20)}; + --duration: #{get-duration($i)}; } .staggerDuration#{$i} { - --stagger-duration: #{get-duration($i, 20)}; + --stagger-duration: #{get-duration($i)}; } }