Skip to content

Commit 0cdfb96

Browse files
committed
0.0.6
1 parent 06c919e commit 0cdfb96

File tree

3 files changed

+28
-12
lines changed

3 files changed

+28
-12
lines changed

dist/vue-highcharts.js

Lines changed: 26 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -29,29 +29,45 @@ function create(tagName, Highcharts) {
2929
}
3030
: { options: { type: Object, required: true } },
3131
methods: {
32+
_init: function() {
33+
this._renderChart();
34+
if (isRenderer) {
35+
this.$watch('width', this._renderChart);
36+
this.$watch('height', this._renderChart);
37+
} else {
38+
this.$watch('options', this._renderChart, { deep: true });
39+
}
40+
},
3241
_renderChart: function() {
3342
if (isRenderer) {
43+
this.renderer && this.$el.removeChild(this.renderer.box);
3444
this.renderer = new Ctor(this.$el, this.width, this.height);
3545
} else {
36-
var opts = this.options || {};
37-
opts.chart = opts.chart || {};
38-
opts.chart.renderTo = this.$el;
39-
this.chart = new Ctor(opts);
46+
var opts = {};
47+
for (var property in this.options) {
48+
opts[property] = this.options[property];
49+
}
50+
this.chart = new Ctor(this.$el, opts);
4051
}
4152
}
4253
},
4354
mounted: function() {
44-
this._renderChart();
45-
},
46-
updated: function() {
47-
this._renderChart();
55+
this._init();
4856
},
4957
beforeDestroy: function() {
50-
!isRenderer && this.chart.destroy();
58+
if (isRenderer) {
59+
this.$el.removeChild(this.renderer.box);
60+
for (var property in this.renderer) {
61+
delete this.renderer[property];
62+
}
63+
this.renderer = null;
64+
} else {
65+
this.chart.destroy();
66+
}
5167
},
5268
// compat Vue v1.x
5369
ready: function() {
54-
this._renderChart();
70+
this._init();
5571
}
5672
};
5773
}

dist/vue-highcharts.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "vue-highcharts",
3-
"version": "0.0.5",
3+
"version": "0.0.6",
44
"description": "Highcharts component for Vue",
55
"main": "dist/vue-highcharts.js",
66
"jsnext:main": "src/index.js",

0 commit comments

Comments
 (0)