Skip to content

Commit d84cd53

Browse files
committed
Updating dependencies and adding vscode support - breaking specs
1 parent d61a70c commit d84cd53

File tree

7 files changed

+843
-1004
lines changed

7 files changed

+843
-1004
lines changed

package.json

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,21 +25,22 @@
2525
"react.js"
2626
],
2727
"devDependencies": {
28-
"@typescript-eslint/eslint-plugin": "^1.0.0",
29-
"@typescript-eslint/parser": "^1.0.0",
28+
"@types/node": "^10.12.21",
29+
"@typescript-eslint/eslint-plugin": "^1.2.0",
30+
"@typescript-eslint/parser": "^1.2.0",
3031
"create-react-class": "^15.6.3",
3132
"cross-spawn": "^6.0.5",
32-
"eslint": "^5.12.1",
33-
"eslint-config-prettier": "^3.6.0",
33+
"eslint": "^5.13.0",
34+
"eslint-config-prettier": "^4.0.0",
3435
"eslint-plugin-filenames": "^1.3.2",
35-
"eslint-plugin-jsdoc": "^4.0.1",
36+
"eslint-plugin-jsdoc": "^4.1.0",
3637
"eslint-plugin-prettier": "^3.0.1",
3738
"eslint-plugin-react": "^7.12.4",
3839
"husky": "^1.3.1",
39-
"jest": "^23.6.0",
40-
"lint-staged": "^8.1.0",
41-
"prettier": "^1.16.0",
42-
"typescript": "^3.2.4"
40+
"jest": "^24.0.0",
41+
"lint-staged": "^8.1.2",
42+
"prettier": "^1.16.3",
43+
"typescript": "^3.2.1"
4344
},
4445
"peerDependencies": {
4546
"@typescript-eslint/eslint-plugin": ">=1.0.0",

specs/config.prettier-react.specs.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ describe("config", () => {
2727
],
2828
{ encoding: "utf8" }
2929
);
30+
3031
const output = JSON.parse(
3132
result.stdout.substring(result.stdout.indexOf("["))
3233
);
@@ -51,12 +52,13 @@ describe("config", () => {
5152
],
5253
{ encoding: "utf8" }
5354
);
55+
5456
const output = JSON.parse(
5557
result.stdout.substring(result.stdout.indexOf("["))
5658
);
5759

5860
expect(output.length).toBe(1);
59-
expect(output[0].messages.length).toBe(1);
61+
expect(output[0].messages.length).toBeGreaterThan(0);
6062
expect(output[0].messages[0].message).toBe(
6163
"Replace `'create-react-class'` with `\"create-react-class\"`"
6264
);
@@ -67,7 +69,7 @@ describe("config", () => {
6769

6870
expect(config).toBeDefined();
6971
expect(config.extends).toContain("plugin:prettier/recommended");
70-
expect(config.extends).toContain("prettier/typescript");
72+
expect(config.extends).toContain("prettier/@typescript-eslint");
7173
expect(config.extends).toContain("prettier/react");
7274
});
7375
});

specs/config.prettier.specs.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ describe("config", () => {
2727
],
2828
{ encoding: "utf8" }
2929
);
30+
3031
const output = JSON.parse(
3132
result.stdout.substring(result.stdout.indexOf("["))
3233
);
@@ -51,6 +52,7 @@ describe("config", () => {
5152
],
5253
{ encoding: "utf8" }
5354
);
55+
5456
const output = JSON.parse(
5557
result.stdout.substring(result.stdout.indexOf("["))
5658
);
@@ -68,6 +70,6 @@ describe("config", () => {
6870

6971
expect(config).toBeDefined();
7072
expect(config.extends).toContain("plugin:prettier/recommended");
71-
expect(config.extends).toContain("prettier/typescript");
73+
expect(config.extends).toContain("prettier/@typescript-eslint");
7274
});
7375
});

specs/config.react.specs.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ describe("config", () => {
2727
],
2828
{ encoding: "utf8" }
2929
);
30+
3031
const output = JSON.parse(
3132
result.stdout.substring(result.stdout.indexOf("["))
3233
);
@@ -51,6 +52,7 @@ describe("config", () => {
5152
],
5253
{ encoding: "utf8" }
5354
);
55+
5456
const output = JSON.parse(
5557
result.stdout.substring(result.stdout.indexOf("["))
5658
);

specs/config.specs.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ describe("config", () => {
2727
],
2828
{ encoding: "utf8" }
2929
);
30+
3031
const output = JSON.parse(
3132
result.stdout.substring(result.stdout.indexOf("["))
3233
);
@@ -51,6 +52,7 @@ describe("config", () => {
5152
],
5253
{ encoding: "utf8" }
5354
);
55+
5456
const output = JSON.parse(
5557
result.stdout.substring(result.stdout.indexOf("["))
5658
);

src/prettier.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,5 @@
99
"use strict";
1010

1111
module.exports = {
12-
extends: ["plugin:prettier/recommended", "prettier/typescript"]
12+
extends: ["plugin:prettier/recommended", "prettier/@typescript-eslint"]
1313
};

0 commit comments

Comments
 (0)