fix/crash in data channel stats (#327)

Author: lookback-hugotunius

webrtc/src/data_channel/mod.rs

@@ -550,10 +550,8 @@ impl RTCDataChannel {
     }
 
     pub(crate) async fn collect_stats(&self, collector: &StatsCollector) {
-        collector.insert(
-            self.stats_id.clone(),
-            StatsReportType::DataChannel(DataChannelStats::from(self)),
-        );
+        let stats = DataChannelStats::from(self).await;
+        collector.insert(self.stats_id.clone(), StatsReportType::DataChannel(stats));
     }
 
     pub(crate) fn set_ready_state(&self, r: RTCDataChannelState) {

webrtc/src/sctp_transport/mod.rs

@@ -374,7 +374,7 @@ impl RTCSctpTransport {
 
         // data channels
         let mut data_channels_closed = 0;
-        let data_channels = self.data_channels.try_lock().unwrap();
+        let data_channels = self.data_channels.lock().await;
         for data_channel in &*data_channels {
             match data_channel.ready_state() {
                 RTCDataChannelState::Connecting => (),

webrtc/src/stats/mod.rs

@@ -367,16 +367,16 @@ pub struct DataChannelStats {
     pub state: RTCDataChannelState,
 }
 
-impl From<&RTCDataChannel> for DataChannelStats {
-    fn from(data_channel: &RTCDataChannel) -> Self {
+impl DataChannelStats {
+    pub(crate) async fn from(data_channel: &RTCDataChannel) -> Self {
         let state = data_channel.ready_state();
 
         let mut bytes_received = 0;
         let mut bytes_sent = 0;
         let mut messages_received = 0;
         let mut messages_sent = 0;
 
-        let lock = data_channel.data_channel.try_lock().unwrap();
+        let lock = data_channel.data_channel.lock().await;
 
         if let Some(internal) = &*lock {
             bytes_received = internal.bytes_received();
@@ -385,7 +385,7 @@ impl From<&RTCDataChannel> for DataChannelStats {
             messages_sent = internal.messages_sent();
         }
 
-        DataChannelStats {
+        Self {
             bytes_received,
             bytes_sent,
             data_channel_identifier: data_channel.id(), // TODO: "The value is initially null"