Improved top rewriting, addressing #54

Author: ikreymer

pywb/rewrite/regex_rewriters.py

@@ -136,7 +136,7 @@ def __init__(self, rewriter, rules=[], prefix='WB_wombat_'):
             (r'(?<=document\.)cookie', RegexRewriter.add_prefix(prefix), 0),
 
             #todo: move to mixin?
-            (r'(?:[\s=(){]|^)(top)(?:[\s!=}()]|$)',
+            (r'(?:[\s=(){]|^)(top)\s*(?:[!}()]|==|$)',
              RegexRewriter.add_prefix(prefix), 1),
 
             (r'(?<=window\.)top',

pywb/rewrite/test/test_regex_rewriters.py

@@ -45,6 +45,16 @@
 >>> _test_js('document_domain = "anotherdomain.com"; window.document.domain = "example.com"')
 'document_domain = "anotherdomain.com"; window.document.WB_wombat_domain = "example.com"'
 
+# top test
+>>> _test_js('window.top != window')
+'window.WB_wombat_top != window'
+
+>>> _test_js('top != window')
+'WB_wombat_top != window'
+
+>>> _test_js('top = top + 5')
+'top = top + 5'
+
 # protocol-rel escapes
 >>> _test_js('"//example.com/"')
 '"/web/20131010/http://example.com/"'