feat: emit an error on broken HTML syntax when minimization is enabled (#229)

Author: evilebottnawi

src/index.js

@@ -106,7 +106,11 @@ export default function htmlLoader(source) {
           }
         : minimize;
 
-    content = minify(content, minimizeOptions);
+    try {
+      content = minify(content, minimizeOptions);
+    } catch (error) {
+      this.emitError(error);
+    }
   }
 
   if (options.interpolate && options.interpolate !== 'require') {

test/__snapshots__/minimize-option.test.js.snap

@@ -790,6 +790,31 @@ Text ><img src=\\"/webpack/public/path/image.png\\">--> "
 
 exports[`"minimize" option should support options for minimizer: warnings 1`] = `Array []`;
 
+exports[`"minimize" option should work emit an error on broken HTML syntax: errors 1`] = `
+Array [
+  "ModuleError: Module Error (from /path/to/file.js):
+Parse Error: < img src=\\"image.png\\" >",
+]
+`;
+
+exports[`"minimize" option should work emit an error on broken HTML syntax: module 1`] = `
+"// Imports
+var ___HTML_LOADER_GET_URL_IMPORT___ = require(\\"../../src/runtime/getUrl.js\\");
+var ___HTML_LOADER_IDENT_0___ = require(\\"./image.png\\");
+var ___HTML_LOADER_IDENT_1___ = require(\\"./image.png\\");
+// Exports
+module.exports = \\"Text < img src=\\\\\\"image.png\\\\\\" >\\\\nText <<img src=\\\\\\"\\" + ___HTML_LOADER_GET_URL_IMPORT___(___HTML_LOADER_IDENT_0___) + \\"\\\\\\">\\\\nText ><img src=\\\\\\"\\" + ___HTML_LOADER_GET_URL_IMPORT___(___HTML_LOADER_IDENT_1___) + \\"\\\\\\">\\\\n\\";"
+`;
+
+exports[`"minimize" option should work emit an error on broken HTML syntax: result 1`] = `
+"Text < img src=\\"image.png\\" >
+Text <<img src=\\"/webpack/public/path/image.png\\">
+Text ><img src=\\"/webpack/public/path/image.png\\">
+"
+`;
+
+exports[`"minimize" option should work emit an error on broken HTML syntax: warnings 1`] = `Array []`;
+
 exports[`"minimize" option should work with a value equal to "true": errors 1`] = `Array []`;
 
 exports[`"minimize" option should work with a value equal to "true": module 1`] = `

test/fixtures/broken-html-syntax.html

@@ -0,0 +1,3 @@
+Text < img src="image.png" >
+Text <<img src="image.png">
+Text ><img src="image.png">

test/fixtures/broken-html-syntax.js

@@ -0,0 +1,3 @@
+import html from './broken-html-syntax.html';
+
+export default html;

test/helpers/normalizeErrors.js

@@ -9,7 +9,9 @@ function removeCWD(str) {
     cwd = cwd.replace(/\\/g, '/');
   }
 
-  return str.replace(new RegExp(cwd, 'g'), '');
+  return str
+    .replace(new RegExp(cwd, 'g'), '')
+    .replace(/\(from (.*)\)/, '(from /path/to/file.js)');
 }
 
 export default (errors) => {

test/minimize-option.test.js

@@ -97,4 +97,18 @@ describe('"minimize" option', () => {
     expect(getWarnings(stats)).toMatchSnapshot('warnings');
     expect(getErrors(stats)).toMatchSnapshot('errors');
   });
+
+  it('should work emit an error on broken HTML syntax', async () => {
+    const compiler = getCompiler('broken-html-syntax.js', { minimize: true });
+    const stats = await compile(compiler);
+
+    expect(getModuleSource('./broken-html-syntax.html', stats)).toMatchSnapshot(
+      'module'
+    );
+    expect(
+      execute(readAsset('main.bundle.js', compiler, stats))
+    ).toMatchSnapshot('result');
+    expect(getWarnings(stats)).toMatchSnapshot('warnings');
+    expect(getErrors(stats)).toMatchSnapshot('errors');
+  });
 });