Skip to content

Commit d6590b0

Browse files
cap-Bernarditocap-Bernardito
authored
fix: getting hash for sources (#342)
1 parent e7f3bba commit d6590b0

File tree

6 files changed

+47
-47
lines changed

6 files changed

+47
-47
lines changed

‎src/plugins/source-plugin.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -205,8 +205,8 @@ export default (options) =>
205205
const indexHash = normalizedUrl.lastIndexOf('#');
206206

207207
if (indexHash >= 0) {
208-
hash = normalizedUrl.substr(indexHash, indexHash);
209-
normalizedUrl = normalizedUrl.substr(0, indexHash);
208+
hash = normalizedUrl.substring(indexHash);
209+
normalizedUrl = normalizedUrl.substring(0, indexHash);
210210
}
211211

212212
const request = requestify(normalizedUrl);

‎test/__snapshots__/attributes-option.test.js.snap

Lines changed: 24 additions & 24 deletions
Large diffs are not rendered by default.

‎test/__snapshots__/esModule-option.test.js.snap

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ var ___HTML_LOADER_REPLACEMENT_1___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(_
3232
var ___HTML_LOADER_REPLACEMENT_2___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(___HTML_LOADER_IMPORT_1___);
3333
var ___HTML_LOADER_REPLACEMENT_3___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(___HTML_LOADER_IMPORT_2___);
3434
var ___HTML_LOADER_REPLACEMENT_4___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(___HTML_LOADER_IMPORT_3___);
35-
var ___HTML_LOADER_REPLACEMENT_5___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(___HTML_LOADER_IMPORT_4___, { hash: \\"#hash\\" });
35+
var ___HTML_LOADER_REPLACEMENT_5___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(___HTML_LOADER_IMPORT_4___, { hash: \\"#icon-chevron-with-circle-up\\" });
3636
var ___HTML_LOADER_REPLACEMENT_6___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(___HTML_LOADER_IMPORT_5___);
3737
var ___HTML_LOADER_REPLACEMENT_7___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(___HTML_LOADER_IMPORT_6___);
3838
var ___HTML_LOADER_REPLACEMENT_8___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(___HTML_LOADER_IMPORT_7___);
@@ -112,7 +112,7 @@ exports[`'esModule' option should use a CommonJS export by default: result 1`] =
112112
<custom-element custom-src=\\"image.png\\" />
113113
<custom-img custom-src=\\"image.png\\"/></custom-element>
114114
115-
<img src=\\"/webpack/public/path/icons.svg#hash\\">
115+
<img src=\\"/webpack/public/path/icons.svg#icon-chevron-with-circle-up\\">
116116
117117
<a href=\\"mailto:username@exampledomain.com\\"></a>
118118
@@ -505,7 +505,7 @@ var ___HTML_LOADER_REPLACEMENT_1___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(_
505505
var ___HTML_LOADER_REPLACEMENT_2___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(___HTML_LOADER_IMPORT_1___);
506506
var ___HTML_LOADER_REPLACEMENT_3___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(___HTML_LOADER_IMPORT_2___);
507507
var ___HTML_LOADER_REPLACEMENT_4___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(___HTML_LOADER_IMPORT_3___);
508-
var ___HTML_LOADER_REPLACEMENT_5___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(___HTML_LOADER_IMPORT_4___, { hash: \\"#hash\\" });
508+
var ___HTML_LOADER_REPLACEMENT_5___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(___HTML_LOADER_IMPORT_4___, { hash: \\"#icon-chevron-with-circle-up\\" });
509509
var ___HTML_LOADER_REPLACEMENT_6___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(___HTML_LOADER_IMPORT_5___);
510510
var ___HTML_LOADER_REPLACEMENT_7___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(___HTML_LOADER_IMPORT_6___);
511511
var ___HTML_LOADER_REPLACEMENT_8___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(___HTML_LOADER_IMPORT_7___);
@@ -585,7 +585,7 @@ exports[`'esModule' option should use a CommonJS export when the value is "false
585585
<custom-element custom-src=\\"image.png\\" />
586586
<custom-img custom-src=\\"image.png\\"/></custom-element>
587587
588-
<img src=\\"/webpack/public/path/icons.svg#hash\\">
588+
<img src=\\"/webpack/public/path/icons.svg#icon-chevron-with-circle-up\\">
589589
590590
<a href=\\"mailto:username@exampledomain.com\\"></a>
591591
@@ -978,7 +978,7 @@ var ___HTML_LOADER_REPLACEMENT_1___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(_
978978
var ___HTML_LOADER_REPLACEMENT_2___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(___HTML_LOADER_IMPORT_1___);
979979
var ___HTML_LOADER_REPLACEMENT_3___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(___HTML_LOADER_IMPORT_2___);
980980
var ___HTML_LOADER_REPLACEMENT_4___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(___HTML_LOADER_IMPORT_3___);
981-
var ___HTML_LOADER_REPLACEMENT_5___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(___HTML_LOADER_IMPORT_4___, { hash: \\"#hash\\" });
981+
var ___HTML_LOADER_REPLACEMENT_5___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(___HTML_LOADER_IMPORT_4___, { hash: \\"#icon-chevron-with-circle-up\\" });
982982
var ___HTML_LOADER_REPLACEMENT_6___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(___HTML_LOADER_IMPORT_5___);
983983
var ___HTML_LOADER_REPLACEMENT_7___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(___HTML_LOADER_IMPORT_6___);
984984
var ___HTML_LOADER_REPLACEMENT_8___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(___HTML_LOADER_IMPORT_7___);
@@ -1058,7 +1058,7 @@ exports[`'esModule' option should use an ES module export when the value is "tru
10581058
<custom-element custom-src=\\"image.png\\" />
10591059
<custom-img custom-src=\\"image.png\\"/></custom-element>
10601060
1061-
<img src=\\"/webpack/public/path/icons.svg#hash\\">
1061+
<img src=\\"/webpack/public/path/icons.svg#icon-chevron-with-circle-up\\">
10621062
10631063
<a href=\\"mailto:username@exampledomain.com\\"></a>
10641064

‎test/__snapshots__/loader.test.js.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ var ___HTML_LOADER_REPLACEMENT_1___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(_
155155
var ___HTML_LOADER_REPLACEMENT_2___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(___HTML_LOADER_IMPORT_1___);
156156
var ___HTML_LOADER_REPLACEMENT_3___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(___HTML_LOADER_IMPORT_2___);
157157
var ___HTML_LOADER_REPLACEMENT_4___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(___HTML_LOADER_IMPORT_3___);
158-
var ___HTML_LOADER_REPLACEMENT_5___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(___HTML_LOADER_IMPORT_4___, { hash: \\"#hash\\" });
158+
var ___HTML_LOADER_REPLACEMENT_5___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(___HTML_LOADER_IMPORT_4___, { hash: \\"#icon-chevron-with-circle-up\\" });
159159
var ___HTML_LOADER_REPLACEMENT_6___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(___HTML_LOADER_IMPORT_5___);
160160
var ___HTML_LOADER_REPLACEMENT_7___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(___HTML_LOADER_IMPORT_6___);
161161
var ___HTML_LOADER_REPLACEMENT_8___ = ___HTML_LOADER_GET_SOURCE_FROM_IMPORT___(___HTML_LOADER_IMPORT_7___);
@@ -235,7 +235,7 @@ exports[`loader should work: result 1`] = `
235235
<custom-element custom-src=\\"image.png\\" />
236236
<custom-img custom-src=\\"image.png\\"/></custom-element>
237237
238-
<img src=\\"/webpack/public/path/icons.svg#hash\\">
238+
<img src=\\"/webpack/public/path/icons.svg#icon-chevron-with-circle-up\\">
239239
240240
<a href=\\"mailto:username@exampledomain.com\\"></a>
241241

0 commit comments

Comments
 (0)