Prefer foreach over for (#1107)

Author: spawnia

src/Language/BlockString.php

@@ -32,8 +32,7 @@ public static function dedentValue(string $rawString): string
 
         if ($commonIndent > 0) {
             for ($i = 1; $i < $linesLength; ++$i) {
-                $line = $lines[$i];
-                $lines[$i] = mb_substr($line, $commonIndent);
+                $lines[$i] = mb_substr($lines[$i], $commonIndent);
             }
         }
 

src/Language/Visitor.php

@@ -221,10 +221,7 @@ public static function visit(object $root, array $visitor, ?array $keyMap = null
                     }
 
                     $editOffset = 0;
-                    for ($ii = 0; $ii < count($edits); ++$ii) {
-                        $editKey = $edits[$ii][0];
-                        $editValue = $edits[$ii][1];
-
+                    foreach ($edits as [$editKey, $editValue]) {
                         if ($inArray) {
                             $editKey -= $editOffset;
                         }

src/Validator/Rules/NoFragmentCycles.php

@@ -64,8 +64,7 @@ protected function detectCycleRecursive(FragmentDefinitionNode $fragment, QueryV
 
         $this->spreadPathIndexByName[$fragmentName] = count($this->spreadPath);
 
-        for ($i = 0; $i < count($spreadNodes); ++$i) {
-            $spreadNode = $spreadNodes[$i];
+        foreach ($spreadNodes as $spreadNode) {
             $spreadName = $spreadNode->name->value;
             $cycleIndex = $this->spreadPathIndexByName[$spreadName] ?? null;
 

src/Validator/Rules/OverlappingFieldsCanBeMerged.php

@@ -102,7 +102,7 @@ protected function findConflictsWithinSelectionSet(
 
         $conflicts = [];
 
-        // (A) Find find all conflicts "within" the fields of this selection set.
+        // (A) Find all conflicts "within" the fields of this selection set.
         // Note: this is the *only place* `collectConflictsWithin` is called.
         $this->collectConflictsWithin(
             $context,

tests/Language/LexerTest.php

@@ -14,7 +14,7 @@
 use function json_decode;
 use PHPUnit\Framework\TestCase;
 
-class LexerTest extends TestCase
+final class LexerTest extends TestCase
 {
     use ArraySubsetAsserts;
 

tests/Language/VisitorTest.php

@@ -26,7 +26,7 @@
 use function is_numeric;
 use function Safe\file_get_contents;
 
-class VisitorTest extends ValidatorTestCase
+final class VisitorTest extends ValidatorTestCase
 {
     /**
      * @see it('validates path argument')

tests/Validator/QueryComplexityTest.php

@@ -11,7 +11,7 @@
 use GraphQL\Validator\Rules\QueryComplexity;
 use GraphQL\Validator\ValidationContext;
 
-class QueryComplexityTest extends QuerySecurityTestCase
+final class QueryComplexityTest extends QuerySecurityTestCase
 {
     private static QueryComplexity $rule;
 

tests/Validator/QueryDepthTest.php

@@ -6,7 +6,7 @@
 use function sprintf;
 use function str_replace;
 
-class QueryDepthTest extends QuerySecurityTestCase
+final class QueryDepthTest extends QuerySecurityTestCase
 {
     /**
      * @param array<int, array<string, mixed>> $expectedErrors