Add PHPStan

Author: lruozzi9

.github/workflows/build.yml

@@ -45,6 +45,10 @@ jobs:
                 name: Run CS
                 run: vendor/bin/phpcs --standard=PSR2 src/
 
+            -
+                name: Run PHPStan
+                run: vendor/bin/phpstan analyse
+
             -
                 name: Run PHPSpec
                 run: vendor/bin/phpspec run

composer.json

@@ -19,7 +19,8 @@
     },
     "require-dev": {
         "squizlabs/php_codesniffer": "^3.7",
-        "phpspec/phpspec": "^7.3"
+        "phpspec/phpspec": "^7.3",
+        "phpstan/phpstan": "^1.11"
     },
     "autoload": {
         "psr-4": {

phpstan.neon

@@ -0,0 +1,4 @@
+parameters:
+	level: 6
+	paths:
+		- src

src/Api/EcRequest.php

@@ -165,7 +165,7 @@ private function calculateMac(): string
 
     private function convertAmountToString(float $amount): string
     {
-        return str_pad((string)round($amount, 2)*100, 9, '0', STR_PAD_LEFT);
+        return str_pad((string) (round($amount, 2)*100), 9, '0', STR_PAD_LEFT);
     }
 
     private function validate(): void

src/Notification/Request.php

@@ -41,6 +41,9 @@ class Request implements Signed
 
     private ?string $scadenza_pan;
 
+    /**
+     * @param array<string, string|int> $rawParams
+     */
     private function __construct(array $rawParams)
     {
         $this->checkForMissingParameters($rawParams);
@@ -68,15 +71,15 @@ private function __construct(array $rawParams)
         $this->session_id = $rawParams['session_id'] ?? null;
     }
 
-    public static function buildFromHttpRequest(ServerRequestInterface $request): static
+    public static function buildFromHttpRequest(ServerRequestInterface $request): self
     {
         if (strtoupper($request->getMethod()) === 'POST') {
             $rawParams = $request->getParsedBody();
         } else {
             $rawParams = $request->getQueryParams();
         }
 
-        return new static($rawParams);
+        return new self($rawParams);
     }
 
     public function getAlias(): string
@@ -215,6 +218,9 @@ private function checkForMissingParameters(array $rawParams): void
         }
     }
 
+    /**
+     * @param array<string, string|int> $rawParams
+     */
     private function validateParameters(array $rawParams): void
     {
         $rawAmount = $rawParams['importo'];

src/Signature/DefaultSignatureHashingManager.php

@@ -21,7 +21,7 @@ public function hashSignatureString(string $string, string $method): string
         return $encodedString;
     }
 
-    private function mustEncodeHashResultAsUrlencodedBase64($method): bool
+    private function mustEncodeHashResultAsUrlencodedBase64(string $method): bool
     {
         return $method === SignatureMethod::MD5_METHOD;
     }

src/Signature/Signable.php

@@ -4,6 +4,9 @@
 
 interface Signable
 {
+    /**
+     * @return array<string, string|int>
+     */
     public function getSignatureData(): array;
 
     public function setSignature(string $signature): static;