fixes of variable and config file. (#1)

Author: SaifiKhambhati

config/sms.php

@@ -46,8 +46,11 @@
         'twilio_sms' => Webelightdev\LaravelSms\Drivers\TwilioSms::class,
     ],
 
-    'moduleEnable' => [
-        'sms' => true,
-    ]
+    'enable' => true,
+
+    'status' => [
+        'success' => 0,
+        'failure' => 1,
+    ],
 
 ];

src/Jobs/sendSmsJob.php

@@ -18,7 +18,7 @@ class sendSmsJob implements ShouldQueue
 {
     use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;
 
-    protected $mobile_numbers;
+    protected $mobileNumber;
     protected $message;
     protected $logData;
 
@@ -27,9 +27,9 @@ class sendSmsJob implements ShouldQueue
      *
      * @return void
      */
-    public function __construct($mobile_numbers, $message , $logData)
+    public function __construct($mobileNumber, $message , $logData)
     {
-        $this->mobile_numbers = $mobile_numbers;
+        $this->mobileNumber = $mobileNumber;
         $this->message = $message;
         $this->logData = $logData;
     }
@@ -44,13 +44,13 @@ public function handle()
         $class = config('sms.map.twilio_sms');
 
         $object = new $class;
-        $object->send($this->mobile_numbers, $this->message);
+        $object->send($this->mobileNumber, $this->message);
 
         $data = [
             'message_date'  => Carbon::now(),
-            'mobile_no'     => $this->mobile_numbers,
+            'mobile_no'     => $this->mobileNumber,
             'message_body'   => $this->message,
-            'status'         => config('thunderSchool.mail_status.success'),
+            'status'         => config('sms.status.success'),
             'status_message' => 'No errors.',
         ];
         SmsLog::create(array_merge($data, $this->logData));   
@@ -60,9 +60,9 @@ public function failed(Exception $exception)
     {
         $data = [
             'message_date'  => Carbon::now(),
-            'mobile_no'     => $this->mobile_numbers,
+            'mobile_no'     => $this->mobileNumber,
             'message_body'   => $this->message,
-            'status'         => config('thunderSchool.mail_status.failure'),
+            'status'         => config('sms.status.failure'),
             'status_message' => $exception->getMessage(),
         ];
         SmsLog::create(array_merge($data, $this->logData));

src/SmsManager.php

@@ -54,9 +54,9 @@ public function with($driver)
      * @param $callback
      * @return mixed
      */
-    public function send($message, $mobile_numbers, $logData = [] ,$callback)
+    public function send($message, $mobileNumbers, $logData = [] ,$callback)
     {
-        $smsEnable = config('sms.moduleEnable.sms');
+        $smsEnable = config('sms.enable');
 
         if ($smsEnable) {
             $this->validateParams();            
@@ -66,7 +66,7 @@ public function send($message, $mobile_numbers, $logData = [] ,$callback)
 
             call_user_func($callback, $object);
 
-            foreach ($mobile_numbers as $recipient) {
+            foreach ($mobileNumbers as $recipient) {
                Queue::push(new sendSmsJob($recipient, $message, $logData));
             }
             return response()->json(['success' => "message sent successfully"], 200);