control panel payment gateway modal init

[smockensturm]

Description

Control Panel payment gateway modal is wonky.

Steps to reproduce

1. Manually add an order
2. Manually add a transaction
3. Close the payment modal
4. Open the payment modal again (add transaction)

The gateway (in our case Braintree) fails to instantiate on subsequent modal opening. Fields appear but dead.
Refresh the page and pop it again (first time) and the fields will initialize.

we do get the "harmless" console warning "Double-instantiating a menu button on an element" from garnish.js

Additional info

• Craft CMS version: Craft Pro 3.7.12
• Craft Commerce version: 3.4.2
• PHP version: 7.4.22
• Database driver & version: MySQL 8.0.20
• Plugins & versions:

Amazon S3 1.2.15
Aws serverless image handler 1.1.4
Braintree for Craft Commerce 2.4.0
Colour Swatches 1.4.2
Control Panel CSS 2.3.1
Craft Commerce 3.4.2
Feed Me 4.4.0
Gift Voucher 2.6.1
Klaviyo Connect 4.0.6
oEmbed 1.3.12
Redactor 2.8.8
SEOMate 1.1.11
ShipStation Connect 1.3.6
Sprig 1.8.1
Stamped 1.0.1
Super Table 2.6.8
Tags 1.0.7
Typed link field 1.0.25

[smockensturm]

@pdaleramirez sent me

craftcms/commerce#2566

[smockensturm]

Hello? Anything?