fix concurrent report read while writing

mblaschke · mblaschke · commit c0dd3320f24c · 2022-10-01T01:26:56.000+02:00
Signed-off-by: Markus Blaschke &lt;mblaschke82@gmail.com&gt;
diff --git a/auditor/auditor.go b/auditor/auditor.go
@@ -8,7 +8,6 @@ import (
 	"time"
 
 	"github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armsubscriptions"
-	"github.com/Azure/go-autorest/autorest"
 	"github.com/Azure/go-autorest/autorest/to"
 	"github.com/patrickmn/go-cache"
 	cron "github.com/robfig/cron/v3"
@@ -376,6 +375,8 @@ func (auditor *AzureAuditor) initCron() {
 }
 
 func (auditor *AzureAuditor) GetReport() map[string]*AzureAuditorReport {
+	auditor.reportLock.RLock()
+	defer auditor.reportLock.RUnlock()
 	return auditor.report
 }
 

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,6 @@ import (`
`8`	`8`	`"time"`
`9`	`9`
`10`	`10`	`"github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armsubscriptions"`
`11`		`- "github.com/Azure/go-autorest/autorest"`
`12`	`11`	`"github.com/Azure/go-autorest/autorest/to"`
`13`	`12`	`"github.com/patrickmn/go-cache"`
`14`	`13`	`cron "github.com/robfig/cron/v3"`
`@@ -376,6 +375,8 @@ func (auditor *AzureAuditor) initCron() {`
`376`	`375`	`}`
`377`	`376`
`378`	`377`	`func (auditor AzureAuditor) GetReport() map[string]AzureAuditorReport {`
	`378`	`+ auditor.reportLock.RLock()`
	`379`	`+ defer auditor.reportLock.RUnlock()`
`379`	`380`	`return auditor.report`
`380`	`381`	`}`
`381`	`382`