Skip to content

Commit e07a148

Browse files
committed
Fix typos, potential fix for #96
1 parent 25e1928 commit e07a148

File tree

4 files changed

+4
-9
lines changed

4 files changed

+4
-9
lines changed

lib/keyUtils.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -489,11 +489,6 @@ class PublicKey {
489489
return this._original_pem;
490490
} else if (this.getKey()) {
491491
let pemResult = abToPem("PUBLIC KEY",await tools.webcrypto.subtle.exportKey("spki", this.getKey()));
492-
493-
// Add trailing \n if missing (Deno only)
494-
if (pemResult[pemResult.length - 1] !== "\n") {
495-
pemResult += "\n";
496-
}
497492

498493
return pemResult;
499494
} else {

lib/utils.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -223,13 +223,13 @@ function pemToBase64(pem) {
223223
}
224224

225225
// Remove trailing \n
226-
pem = pem.replace(/^\n/, "");
226+
pem = pem.replace(/\n$/, "");
227227

228228
// Split on \n
229229
let pemArr = pem.split("\n");
230230

231231
// remove first and last lines
232-
pemArr = pemArr.slice(1, pemArr.length - 2);
232+
pemArr = pemArr.slice(1, pemArr.length - 1);
233233
return pemArr.join("");
234234
}
235235

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "fido2-lib",
3-
"version": "3.2.2",
3+
"version": "3.2.3",
44
"description": "A library for performing FIDO 2.0 / WebAuthn functionality",
55
"type": "module",
66
"main": "dist/main.cjs",

test/keyUtils.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ describe("key utils", function() {
6868
describe("rsa spki 2048 bits without trailing newline", function() {
6969
const k = new PublicKey();
7070
it("can import", async () => {
71-
await k.fromPem(rsaPublicKey.pem2048);
71+
await k.fromPem(rsaPublicKey.pem2048noTrailingN);
7272
});
7373
});
7474

0 commit comments

Comments
 (0)