Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Commit 7a8df69

Browse files
update typescript version to 5 (#7272)
* upgrade typescript to v5 * fix some issues detected by typescript v5 * fix lint issues after the typescript version upgrade
1 parent 984cb7c commit 7a8df69

File tree

68 files changed

+191
-131
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

68 files changed

+191
-131
lines changed

.gitignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ tmp
3434
lib/
3535
dist/
3636
tsconfig.tsbuildinfo
37+
tsconfig.types.tsbuildinfo
3738

3839
# Unsupported lock files
3940
package-lock.json
@@ -48,4 +49,4 @@ benchmark-data.txt
4849

4950
.eslintcache
5051

51-
.history
52+
.history

fixtures/utils.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ export const processAsync = async (
1818
processFunc: (
1919
resolver: (value: unknown) => void,
2020
reject: (value: unknown) => void,
21+
// eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents
2122
) => Promise<unknown> | unknown,
2223
) =>
2324
new Promise((resolve, reject) => {

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@
137137
"typedoc-plugin-markdown": "^3.17.0",
138138
"typedoc-plugin-mdn-links": "^2.0.0",
139139
"typedoc-plugin-merge-modules": "^5.1.0",
140-
"typescript": "^4.7.4",
140+
"typescript": "^5.5.4",
141141
"utf-8-validate": "^5.0.9",
142142
"web3-hardhat-plugin": "^1.0.0",
143143
"webpack": "^5.73.0",

packages/web3-account-abstraction/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
"jest-extended": "^3.0.1",
5454
"prettier": "^2.7.1",
5555
"ts-jest": "^29.1.1",
56-
"typescript": "^4.7.4"
56+
"typescript": "^5.5.4"
5757
},
5858
"dependencies": {
5959
"web3-core": "^4.7.0",

packages/web3-core/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,6 @@
6868
"jest-when": "^3.5.1",
6969
"prettier": "^2.7.1",
7070
"ts-jest": "^29.1.1",
71-
"typescript": "^4.7.4"
71+
"typescript": "^5.5.4"
7272
}
7373
}

packages/web3-core/src/web3_subscription_manager.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,7 @@ export class Web3SubscriptionManager<
163163
const subscription = new Klass(args ?? undefined, {
164164
subscriptionManager: this as Web3SubscriptionManager<API, RegisteredSubs>,
165165
returnFormat,
166+
// eslint.disable-next-line @typescript-eslint/no-unsafe-any
166167
} as any) as InstanceType<RegisteredSubs[T]>;
167168

168169
await this.addSubscription(subscription);

packages/web3-core/test/unit/web3_promi_event.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ describe('Web3PromiEvent', () => {
134134
});
135135

136136
const f = jest.fn();
137-
p.finally(f);
137+
await p.finally(f);
138138
await p;
139139
expect(f).toHaveBeenCalled();
140140
});

packages/web3-errors/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,6 @@
5555
"jest-extended": "^3.0.1",
5656
"prettier": "^2.7.1",
5757
"ts-jest": "^29.1.1",
58-
"typescript": "^4.7.4"
58+
"typescript": "^5.5.4"
5959
}
6060
}

packages/web3-errors/src/errors/contract_errors.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,7 @@ export class Eip838ExecutionError extends Web3ContractError {
150150
super(error.message || 'Error');
151151

152152
this.name = ('name' in error && error.name) || this.constructor.name;
153+
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
153154
this.stack = ('stack' in error && error.stack) || undefined;
154155
this.code = error.code;
155156

packages/web3-eth-abi/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,6 @@
6363
"jest-when": "^3.5.1",
6464
"prettier": "^2.7.1",
6565
"ts-jest": "^29.1.1",
66-
"typescript": "^4.7.4"
66+
"typescript": "^5.5.4"
6767
}
6868
}

0 commit comments

Comments
 (0)