fix: remove several ts-expect-error (#2409)

Author: HerringtonDarkholme

packages/rspack/src/config/adapter-rule-use.ts

@@ -158,8 +158,8 @@ function createRawModuleRuleUsesImpl(
 			use.loader.startsWith(BUILTIN_LOADER_PREFIX)
 	);
 	if (index < 0) {
-		// @ts-expect-error
-		return [composeJsUse(uses, options, allUses)];
+		// cast to non-null since we know `uses` is not empty
+		return [composeJsUse(uses, options, allUses)!];
 	}
 
 	const before = uses.slice(0, index);
@@ -205,14 +205,10 @@ function composeJsUse(
 				let isSync = true;
 				let isError = false; // internal error
 				let reportedError = false;
-				// @ts-expect-error
-				const fileDependencies = [];
-				// @ts-expect-error
-				const contextDependencies = [];
-				// @ts-expect-error
-				const missingDependencies = [];
-				// @ts-expect-error
-				const buildDependencies = [];
+				const fileDependencies: string[] = [];
+				const contextDependencies: string[] = [];
+				const missingDependencies: string[] = [];
+				const buildDependencies: string[] = [];
 
 				function callback(
 					err: Error | null,
@@ -238,13 +234,9 @@ function composeJsUse(
 						content,
 						sourceMap,
 						additionalData,
-						// @ts-expect-error
 						fileDependencies,
-						// @ts-expect-error
 						contextDependencies,
-						// @ts-expect-error
 						missingDependencies,
-						// @ts-expect-error
 						buildDependencies
 					});
 				}
@@ -476,15 +468,12 @@ function composeJsUse(
 						missingDependencies.length = 0;
 					},
 					getDependencies() {
-						// @ts-expect-error
 						return fileDependencies.slice();
 					},
 					getContextDependencies() {
-						// @ts-expect-error
 						return contextDependencies.slice();
 					},
 					getMissingDependencies() {
-						// @ts-expect-error
 						return missingDependencies.slice();
 					},
 					_compiler: compiler,
@@ -519,16 +508,12 @@ function composeJsUse(
 						if (result === undefined) {
 							resolve({
 								content,
-								// @ts-expect-error
 								buildDependencies,
 								sourceMap,
 								additionalData,
 								cacheable,
-								// @ts-expect-error
 								fileDependencies,
-								// @ts-expect-error
 								contextDependencies,
-								// @ts-expect-error
 								missingDependencies
 							});
 							return;
@@ -537,32 +522,24 @@ function composeJsUse(
 							return result.then(function (result) {
 								resolve({
 									content: result,
-									// @ts-expect-error
 									buildDependencies,
 									sourceMap,
 									additionalData,
 									cacheable,
-									// @ts-expect-error
 									fileDependencies,
-									// @ts-expect-error
 									contextDependencies,
-									// @ts-expect-error
 									missingDependencies
 								});
 							}, reject);
 						}
 						return resolve({
 							content: result,
-							// @ts-expect-error
 							buildDependencies,
 							sourceMap,
 							additionalData,
 							cacheable,
-							// @ts-expect-error
 							fileDependencies,
-							// @ts-expect-error
 							contextDependencies,
-							// @ts-expect-error
 							missingDependencies
 						});
 					}
@@ -614,7 +591,7 @@ function composeJsUse(
 						typeof sourceMap === "string"
 							? sourceMap
 							: JSON.stringify(sourceMap)
-				  )
+					)
 				: undefined,
 			additionalData: additionalData
 				? toBuffer(JSON.stringify(additionalData))