fix: port public path of module chunk loading from webpack (#10425)

* fix: port webpack#19434

* fix: public path output module

* fix: public path output module

Author: LingyuCoder

crates/rspack_plugin_css/src/runtime/css_loading_with_hmr.js

@@ -2,7 +2,7 @@ var oldTags = [];
 var newTags = [];
 var applyHandler = function (options) {
 	return {
-		dispose: function () {},
+		dispose: function () { },
 		apply: function () {
 			var moduleIds = [];
 			newTags.forEach(function (info) {
@@ -15,8 +15,8 @@ var applyHandler = function (options) {
 			while (newTags.length) {
 				var info = newTags.pop();
 				var chunkModuleIds = loadCssChunkData(__webpack_require__.m, info[0]);
-				chunkModuleIds.forEach(function(id) {
-				    moduleIds.push(id)
+				chunkModuleIds.forEach(function (id) {
+					moduleIds.push(id)
 				});
 			}
 			return moduleIds;
@@ -36,6 +36,7 @@ __webpack_require__.hmrC.css = function (
 	applyHandlers,
 	updatedModulesList
 ) {
+	if (typeof document === 'undefined') return;
 	applyHandlers.push(applyHandler);
 	chunkIds.forEach(function (chunkId) {
 		var filename = __webpack_require__.k(chunkId);
@@ -70,11 +71,11 @@ __webpack_require__.hmrC.css = function (
 									if (link.parentNode) link.parentNode.removeChild(link);
 									return resolve();
 								}
-							} catch (e) {}
+							} catch (e) { }
 							var factories = {};
 							loadCssChunkData(factories, link, chunkId);
-							Object.keys(factories).forEach(function(id) {
-							    (updatedModulesList.push(id));
+							Object.keys(factories).forEach(function (id) {
+								(updatedModulesList.push(id));
 							});
 							link.sheet.disabled = true;
 							oldTags.push(oldTag);

crates/rspack_plugin_css/src/runtime/css_loading_with_loading.js

@@ -48,7 +48,11 @@ __webpack_require__.f.css = function (chunkId, promises, fetchPriority) {
 						}
 					}
 				};
-				var link = loadStylesheet(chunkId, url, loadingEnded, undefined, fetchPriority);
+				if (typeof document !== 'undefined') {
+					loadStylesheet(chunkId, url, loadingEnded, undefined, fetchPriority);
+				} else {
+					loadingEnded({ type: 'load' });
+				}
 			} else installedChunks[chunkId] = 0;
 		}
 	}

crates/rspack_plugin_css/src/runtime/mod.rs

@@ -6,7 +6,9 @@ use rspack_core::{
   basic_function, compile_boolean_matcher, impl_runtime_module, BooleanMatcher, ChunkGroupOrderKey,
   ChunkUkey, Compilation, CrossOriginLoading, RuntimeGlobals, RuntimeModule, RuntimeModuleStage,
 };
-use rspack_plugin_runtime::{chunk_has_css, get_chunk_runtime_requirements, stringify_chunks};
+use rspack_plugin_runtime::{
+  chunk_has_css, get_chunk_runtime_requirements, is_neutral_platform, stringify_chunks,
+};
 use rustc_hash::FxHashSet as HashSet;
 
 #[impl_runtime_module]
@@ -61,16 +63,17 @@ impl RuntimeModule for CssLoadingRuntimeModule {
       }
 
       let environment = &compilation.options.output.environment;
+      let is_neutral_platform = is_neutral_platform(compilation);
       let with_prefetch = runtime_requirements.contains(RuntimeGlobals::PREFETCH_CHUNK_HANDLERS)
-        && environment.supports_document()
+        && (environment.supports_document() || is_neutral_platform)
         && chunk.has_child_by_order(
           compilation,
           &ChunkGroupOrderKey::Prefetch,
           true,
           &chunk_has_css,
         );
       let with_preload = runtime_requirements.contains(RuntimeGlobals::PRELOAD_CHUNK_HANDLERS)
-        && environment.supports_document()
+        && (environment.supports_document() || is_neutral_platform)
         && chunk.has_child_by_order(
           compilation,
           &ChunkGroupOrderKey::Preload,

crates/rspack_plugin_runtime/src/helpers.rs

@@ -327,3 +327,14 @@ pub fn get_chunk_runtime_requirements<'a>(
 ) -> &'a RuntimeGlobals {
   ChunkGraph::get_chunk_runtime_requirements(compilation, chunk_ukey)
 }
+
+pub fn is_neutral_platform(compilation: &Compilation) -> bool {
+  // webpack uses `this.compilation.compiler.platform.node`
+  !compilation.options.output.environment.supports_document()
+    && !compilation
+      .options
+      .resolve
+      .condition_names
+      .as_ref()
+      .is_some_and(|c| c.contains(&"node".to_string()))
+}

crates/rspack_plugin_runtime/src/module_chunk_loading.rs

@@ -1,6 +1,6 @@
 use rspack_core::{
   ChunkLoading, ChunkLoadingType, ChunkUkey, Compilation, CompilationRuntimeRequirementInTree,
-  Plugin, PluginContext, RuntimeGlobals, RuntimeModuleExt,
+  Plugin, PluginContext, PublicPath, RuntimeGlobals, RuntimeModuleExt,
 };
 use rspack_error::Result;
 use rspack_hook::{plugin, plugin_hook};
@@ -30,6 +30,11 @@ async fn runtime_requirements_in_tree(
     match runtime_requirement {
       RuntimeGlobals::ENSURE_CHUNK_HANDLERS if is_enabled_for_chunk => {
         has_chunk_loading = true;
+
+        if !matches!(compilation.options.output.public_path, PublicPath::Auto) {
+          runtime_requirements_mut.insert(RuntimeGlobals::PUBLIC_PATH);
+        }
+
         runtime_requirements_mut.insert(RuntimeGlobals::GET_CHUNK_SCRIPT_FILENAME);
       }
       RuntimeGlobals::EXTERNAL_INSTALL_CHUNK if is_enabled_for_chunk => {
@@ -40,6 +45,11 @@ async fn runtime_requirements_in_tree(
       RuntimeGlobals::ON_CHUNKS_LOADED | RuntimeGlobals::BASE_URI if is_enabled_for_chunk => {
         has_chunk_loading = true;
       }
+      RuntimeGlobals::PREFETCH_CHUNK_HANDLERS | RuntimeGlobals::PRELOAD_CHUNK_HANDLERS => {
+        if is_enabled_for_chunk {
+          runtime_requirements_mut.insert(RuntimeGlobals::PUBLIC_PATH);
+        }
+      }
       _ => {}
     }
   }

crates/rspack_plugin_runtime/src/runtime_module/module_chunk_loading.rs

@@ -4,12 +4,13 @@ use cow_utils::CowUtils;
 use rspack_collections::{DatabaseItem, Identifier};
 use rspack_core::{
   compile_boolean_matcher, impl_runtime_module, BooleanMatcher, Chunk, ChunkGroupOrderKey,
-  ChunkUkey, Compilation, CrossOriginLoading, RuntimeGlobals, RuntimeModule, RuntimeModuleStage,
+  ChunkUkey, Compilation, CrossOriginLoading, PublicPath, RuntimeGlobals, RuntimeModule,
+  RuntimeModuleStage,
 };
 
 use super::utils::{chunk_has_js, get_output_dir};
 use crate::{
-  get_chunk_runtime_requirements,
+  get_chunk_runtime_requirements, is_neutral_platform,
   runtime_module::utils::{get_initial_chunk_ids, stringify_chunks},
   LinkPrefetchData, LinkPreloadData, RuntimeModuleChunkWrapper, RuntimePlugin,
 };
@@ -103,22 +104,24 @@ impl RuntimeModule for ModuleChunkLoadingRuntimeModule {
 
     let hooks = RuntimePlugin::get_compilation_hooks(compilation.id());
 
+    let is_neutral_platform = is_neutral_platform(compilation);
+
     let with_base_uri = runtime_requirements.contains(RuntimeGlobals::BASE_URI);
     let with_external_install_chunk =
       runtime_requirements.contains(RuntimeGlobals::EXTERNAL_INSTALL_CHUNK);
     let with_loading = runtime_requirements.contains(RuntimeGlobals::ENSURE_CHUNK_HANDLERS);
     let with_on_chunk_load = runtime_requirements.contains(RuntimeGlobals::ON_CHUNKS_LOADED);
     let with_hmr = runtime_requirements.contains(RuntimeGlobals::HMR_DOWNLOAD_UPDATE_HANDLERS);
     let with_prefetch = runtime_requirements.contains(RuntimeGlobals::PREFETCH_CHUNK_HANDLERS)
-      && compilation.options.output.environment.supports_document()
+      && (compilation.options.output.environment.supports_document() || is_neutral_platform)
       && chunk.has_child_by_order(
         compilation,
         &ChunkGroupOrderKey::Prefetch,
         true,
         &chunk_has_js,
       );
     let with_preload = runtime_requirements.contains(RuntimeGlobals::PRELOAD_CHUNK_HANDLERS)
-      && compilation.options.output.environment.supports_document()
+      && (compilation.options.output.environment.supports_document() || is_neutral_platform)
       && chunk.has_child_by_order(
         compilation,
         &ChunkGroupOrderKey::Preload,
@@ -176,12 +179,17 @@ impl RuntimeModule for ModuleChunkLoadingRuntimeModule {
       let body = if matches!(has_js_matcher, BooleanMatcher::Condition(false)) {
         "installedChunks[chunkId] = 0;".to_string()
       } else {
+        let output_dir = if matches!(compilation.options.output.public_path, PublicPath::Auto) {
+          serde_json::to_string(&root_output_dir).expect("should able to serde_json::to_string")
+        } else {
+          RuntimeGlobals::PUBLIC_PATH.to_string()
+        };
         compilation.runtime_template.render(
           &self.template(TemplateId::WithLoading),
           Some(serde_json::json!({
             "_js_matcher": &has_js_matcher.render("chunkId"),
             "_import_function_name":&compilation.options.output.import_function_name,
-            "_output_dir": &root_output_dir,
+            "_output_dir": &output_dir,
             "_match_fallback":    if matches!(has_js_matcher, BooleanMatcher::Condition(true)) {
               ""
             } else {
@@ -252,6 +260,7 @@ impl RuntimeModule for ModuleChunkLoadingRuntimeModule {
           Some(serde_json::json!({
             "_link_prefetch": &res.code,
             "_js_matcher": &js_matcher,
+            "_is_neutral_platform": is_neutral_platform,
           })),
         )?;
 
@@ -314,6 +323,7 @@ impl RuntimeModule for ModuleChunkLoadingRuntimeModule {
           Some(serde_json::json!({
             "_js_matcher": &js_matcher,
             "_link_preload": &res.code,
+            "_is_neutral_platform": is_neutral_platform,
           })),
         )?;
 

crates/rspack_plugin_runtime/src/runtime_module/runtime/module_chunk_loading_with_loading.ejs

@@ -7,7 +7,7 @@ if (installedChunkData !== 0) { // 0 means "already installed".'
     } else {
         if (<%- _js_matcher %>) {
             // setup Promise in chunk cache
-            var promise = <%- _import_function_name %>("<%- _output_dir %>" + <%- GET_CHUNK_SCRIPT_FILENAME %>(chunkId)).then(installChunk, <%- basicFunction("e") %> {
+            var promise = <%- _import_function_name %>(<%- _output_dir %> + <%- GET_CHUNK_SCRIPT_FILENAME %>(chunkId)).then(installChunk, <%- basicFunction("e") %> {
                 if (installedChunks[chunkId] !== 0) installedChunks[chunkId] = undefined;
                 throw e;
             });

crates/rspack_plugin_runtime/src/runtime_module/runtime/module_chunk_loading_with_prefetch.ejs

@@ -1,5 +1,5 @@
 <%- PREFETCH_CHUNK_HANDLERS %>.j = <%- basicFunction("chunkId") %> {
-    if (typeof document === 'undefined') return;
+    <% if _is_neutral_platform { %>if (typeof document === 'undefined') return;<% } %>
     if((!<%- HAS_OWN_PROPERTY %>(installedChunks, chunkId) || installedChunks[chunkId] === undefined) && <%- _js_matcher %>) {
         installedChunks[chunkId] = null;
         <%- _link_prefetch %>

crates/rspack_plugin_runtime/src/runtime_module/runtime/module_chunk_loading_with_preload.ejs

@@ -1,5 +1,5 @@
 <%- PRELOAD_CHUNK_HANDLERS %>.j = <%- basicFunction("chunkId") %> {
-    if (typeof document === 'undefined') return;
+    <% if _is_neutral_platform { %>if (typeof document === 'undefined') return;<% } %>
     if((!<%- HAS_OWN_PROPERTY %>(installedChunks, chunkId) || installedChunks[chunkId] === undefined) && <%- _js_matcher %>) {
         installedChunks[chunkId] = null;
         <%- _link_preload %>

packages/rspack-test-tools/tests/configCases/library/modern-module-force-concaten/__snapshot__/h.js.txt

@@ -22,9 +22,28 @@ return module.exports;
 }
 
 /************************************************************************/
-// webpack/runtime/public_path
+// webpack/runtime/global
 (() => {
-__webpack_require__.p = "";
+__webpack_require__.g = (() => {
+	if (typeof globalThis === 'object') return globalThis;
+	try {
+		return this || new Function('return this')();
+	} catch (e) {
+		if (typeof window === 'object') return window;
+	}
+})();
+})();
+// webpack/runtime/auto_public_path
+(() => {
+var scriptUrl;
+
+if (typeof import.meta.url === "string") scriptUrl = import.meta.url
+
+// When supporting browsers where an automatic publicPath is not supported you must specify an output.publicPath manually via configuration",
+// or pass an empty string ("") and set the __webpack_public_path__ variable from your code to use your own logic.',
+if (!scriptUrl) throw new Error("Automatic publicPath is not supported in this browser");
+scriptUrl = scriptUrl.replace(/^blob:/, "").replace(/#.*$/, "").replace(/\?.*$/, "").replace(/\/[^\/]+$/, "/");
+__webpack_require__.p = scriptUrl
 })();
 /************************************************************************/