Skip to content

Enhancements for Dependent packages check advisor #54

@NingW101

Description

@NingW101

image

Currently, dep_check advisor will just remove the find_package(XXX) statement but ignore other operations related to this emscripten ported library , which may cause the errors block the building process. We should make enhancements to avoid this problem.

  • For emscripten ported libraries (as shown in the above pictures), webinizer will add -sUSE_LIBXXX into the compiler & linker flags, and emscripten will take responsibilities of linking libraries and including header files directories, so except for find_package statement, the include_directories(${XX_INCLUDE_DIRS}), target_link_libraries(target ${XX_LIBRARIES}) and other operations related to this library are not necessary any more.
  • For the dependencies added from webinizer UI, should also remove the find_package(DEP) statement from the main project, besides, should adjust the statement pattern to target_link_libraries(target -ldepName)

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions