Skip to content

Refactor collection creation to prefer named vectors #1654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dirkkul opened this issue Apr 24, 2025 · 1 comment · May be fixed by #1659
Open

Refactor collection creation to prefer named vectors #1654

dirkkul opened this issue Apr 24, 2025 · 1 comment · May be fixed by #1659
Assignees

Comments

@dirkkul
Copy link
Collaborator

dirkkul commented Apr 24, 2025

Currently we have two ways of creating vector indices:

  • legacy:
        vector_index_config=Configure.VectorIndex.hnsw(),
        vectorizer_config=Configure.Vectorizer.none(),
  • named vectors
        vectorizer_config=[
            wvc.config.Configure.NamedVectors.text2vec_contextionary(
                "title",
                source_properties=["title"],
                vectorize_collection_name=False,
                vector_index_config=wvc.config.Configure.VectorIndex.flat(
                    distance_metric=wvc.config.VectorDistances.HAMMING,
                    quantizer=wvc.config.Configure.VectorIndex.Quantizer.bq(rescore_limit=10),
                ),
            ),
            wvc.config.Configure.NamedVectors.none(
                "custom",
            ),
            wvc.config.Configure.NamedVectors.text2vec_contextionary(
                "default",
                vectorize_collection_name=False,  # needed as contextionary cant handle "_" in collection names
            ),
        ],

Instead we should:

  • deprecate both ways of setting vectorizers in Configure
  • deprecate vectorizer_config
  • replace it with NamedVectorsByDefault that does not contain named vectors
@tsmith023
Copy link
Collaborator

Required core PR: weaviate/weaviate#7933, fixes misalignment between legacy/named vectors API surface for groupBy hits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants