Skip to content

Commit 421482d

Browse files
committed
refactor: update assistant context skill and vis rec v4 tests
1 parent 1b1a1c7 commit 421482d

File tree

2 files changed

+26
-28
lines changed

2 files changed

+26
-28
lines changed

ibm_watson/assistant_v2.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1368,14 +1368,13 @@ class MessageContextSkill():
13681368
13691369
:attr dict user_defined: (optional) Arbitrary variables that can be read and
13701370
written by a particular skill.
1371-
:attr MessageContextSkillSystem system: (optional) System context data used by
1372-
the skill.
1371+
:attr dict system: (optional) System context data used by the skill.
13731372
"""
13741373

13751374
def __init__(self,
13761375
*,
13771376
user_defined: dict = None,
1378-
system: 'MessageContextSkillSystem' = None) -> None:
1377+
system: dict = None) -> None:
13791378
"""
13801379
Initialize a MessageContextSkill object.
13811380

test/integration/test_visual_recognition_v4.py

Lines changed: 24 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -48,17 +48,15 @@ def test_02_images(self):
4848
# name='my_collection', description='just for fun').get_result()
4949
# collection_id = collection.get('collection_id')
5050

51-
# add_images = self.visual_recognition.add_images(
52-
# self.collection_id,
53-
# image_url=[
54-
# "https://upload.wikimedia.org/wikipedia/commons/3/33/KokoniPurebredDogsGreeceGreekCreamWhiteAdult.jpg",
55-
# "https://upload.wikimedia.org/wikipedia/commons/0/07/K%C3%B6nigspudel_Apricot.JPG"
56-
# ],
57-
# ).get_result()
58-
# assert add_images is not None
59-
# image_id = add_images.get('images')[0].get('image_id')
60-
61-
image_id = 'giraffe_00_202349062c2307571a3f7edc71fe819f'
51+
add_images = self.visual_recognition.add_images(
52+
self.collection_id,
53+
image_url=[
54+
"https://upload.wikimedia.org/wikipedia/commons/0/07/K%C3%B6nigspudel_Apricot.JPG"
55+
],
56+
).get_result()
57+
assert add_images is not None
58+
image_id = add_images.get('images')[0].get('image_id')
59+
6260
list_images = self.visual_recognition.list_images(
6361
self.collection_id).get_result()
6462
print(list_images)
@@ -72,7 +70,7 @@ def test_02_images(self):
7270
self.collection_id, image_id).get_result()
7371
assert response.content is not None
7472

75-
# self.visual_recognition.delete_image(self.collection_id, image_id)
73+
self.visual_recognition.delete_image(self.collection_id, image_id)
7674
# self.visual_recognition.delete_collection(collection_id)
7775

7876
def test_03_analyze(self):
@@ -105,19 +103,18 @@ def test_04_objects_and_training(self):
105103
# assert collection_id is not None
106104

107105
# add images
108-
# with open(
109-
# os.path.join(
110-
# os.path.dirname(__file__),
111-
# '../../resources/South_Africa_Luca_Galuzzi_2004.jpeg'),
112-
# 'rb') as giraffe_info:
113-
# add_images_result = self.visual_recognition.add_images(
114-
# self.collection_id,
115-
# images_file=[FileWithMetadata(giraffe_info)],
116-
# ).get_result()
117-
# assert add_images_result is not None
118-
# image_id = add_images_result.get('images')[0].get('image_id')
119-
# assert image_id is not None
120-
image_id = 'giraffe_00_202349062c2307571a3f7edc71fe819f'
106+
with open(
107+
os.path.join(
108+
os.path.dirname(__file__),
109+
'../../resources/South_Africa_Luca_Galuzzi_2004.jpeg'),
110+
'rb') as giraffe_info:
111+
add_images_result = self.visual_recognition.add_images(
112+
self.collection_id,
113+
images_file=[FileWithMetadata(giraffe_info)],
114+
).get_result()
115+
assert add_images_result is not None
116+
image_id = add_images_result.get('images')[0].get('image_id')
117+
assert image_id is not None
121118

122119
# add image training data
123120
training_data = self.visual_recognition.add_image_training_data(
@@ -164,5 +161,7 @@ def test_04_objects_and_training(self):
164161
self.visual_recognition.delete_object(
165162
self.collection_id, object='updated giraffe training data')
166163

164+
self.visual_recognition.delete_image(self.collection_id, image_id)
165+
167166
# delete collection
168167
# self.visual_recognition.delete_collection(collection_id)

0 commit comments

Comments
 (0)