Enables strict null checks in SDK (#2360)

Author: infomiho

waspc/ChangeLog.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## Next
+
+### ⚠️ Breaking Changes
+
+- Renamed and split `deserializeAndSanitizeProviderData` to `getProviderData` and `getProviderDataWithPassword` so it's more explicit if the resulting data will contain the hashed password or not.
+
+### 🔧 Small improvements
+
+- Enabled strict null checks for the Wasp SDK which means that some of the return types are more precise now e.g. you'll need to check if some value is `null` before using it.
+
 ## 0.15.2
 
 ### 🐞 Bug fixes
@@ -79,7 +89,6 @@ To learn more about this feature and how to activate it, check out the [Wasp TS
 There are some breaking changes with React Router 6 which will require you to update your code.
 Also, the new version of Prisma may cause breaking changes depending on how you're using it.
 
-
 Read more about breaking changes in the migration guide: https://wasp-lang.dev/docs/migration-guides/migrate-from-0-14-to-0-15 .
 
 ### 🐞 Bug fixes

waspc/data/Generator/templates/sdk/wasp/api/index.ts

@@ -77,7 +77,7 @@ window.addEventListener('storage', (event) => {
  * standard format to be further used by the client. It is also assumed that given API
  * error has been formatted as implemented by HttpError on the server.
  */
-export function handleApiError(error: AxiosError<{ message?: string, data?: unknown }>): void {
+export function handleApiError<T extends AxiosError<{ message?: string, data?: unknown }>>(error: T): T | WaspHttpError {
   if (error?.response) {
     // If error came from HTTP response, we capture most informative message
     // and also add .statusCode information to it.
@@ -88,10 +88,10 @@ export function handleApiError(error: AxiosError<{ message?: string, data?: unkn
     //   That would require copying HttpError code to web-app also and using it here.
     const responseJson = error.response?.data
     const responseStatusCode = error.response.status
-    throw new WaspHttpError(responseStatusCode, responseJson?.message ?? error.message, responseJson)
+    return new WaspHttpError(responseStatusCode, responseJson?.message ?? error.message, responseJson)
   } else {
     // If any other error, we just propagate it.
-    throw error
+    return error
   }
 }
 

waspc/data/Generator/templates/sdk/wasp/auth/email/actions/login.ts

@@ -8,6 +8,6 @@ export async function login(data: { email: string; password: string }): Promise<
         const response = await api.post('{= loginPath =}', data);
         await initSession(response.data.sessionId);
     } catch (e) {
-        handleApiError(e);
+        throw handleApiError(e);
     }
 }

waspc/data/Generator/templates/sdk/wasp/auth/email/actions/passwordReset.ts

@@ -7,7 +7,7 @@ export async function requestPasswordReset(data: { email: string; }): Promise<{
         const response = await api.post('{= requestPasswordResetPath =}', data);
         return response.data;
     } catch (e) {
-        handleApiError(e);
+        throw handleApiError(e);
     }
 }
 
@@ -17,6 +17,6 @@ export async function resetPassword(data: { token: string; password: string; }):
         const response = await api.post('{= resetPasswordPath =}', data);
         return response.data;
     } catch (e) {
-        handleApiError(e);
+        throw handleApiError(e);
     }
 }

waspc/data/Generator/templates/sdk/wasp/auth/email/actions/signup.ts

@@ -7,6 +7,6 @@ export async function signup(data: { email: string; password: string }): Promise
         const response = await api.post('{= signupPath =}', data);
         return response.data;
     } catch (e) {
-        handleApiError(e);
+        throw handleApiError(e);
     }
 }

waspc/data/Generator/templates/sdk/wasp/auth/email/actions/verifyEmail.ts

@@ -9,6 +9,6 @@ export async function verifyEmail(data: {
     const response = await api.post('{= verifyEmailPath =}', data)
     return response.data
   } catch (e) {
-    handleApiError(e)
+    throw handleApiError(e)
   }
 }

waspc/data/Generator/templates/sdk/wasp/auth/forms/internal/common/LoginSignupForm.tsx

@@ -280,7 +280,7 @@ function AdditionalFormFields({
 }: {
   hookForm: UseFormReturn<LoginSignupFormFields>;
   formState: FormState;
-  additionalSignupFields: AdditionalSignupFields;
+  additionalSignupFields?: AdditionalSignupFields;
 }) {
   const {
     register,
@@ -293,6 +293,7 @@ function AdditionalFormFields({
     Component: any,
     props?: React.ComponentProps<ComponentType>
   ) {
+    const errorMessage = errors[field.name]?.message;
     return (
       <FormItemGroup key={field.name}>
         <FormLabel>{field.label}</FormLabel>
@@ -301,8 +302,8 @@ function AdditionalFormFields({
           {...props}
           disabled={isLoading}
         />
-        {errors[field.name] && (
-          <FormError>{errors[field.name].message}</FormError>
+        {errorMessage && (
+          <FormError>{errorMessage}</FormError>
         )}
       </FormItemGroup>
     );
@@ -341,7 +342,7 @@ function isFieldRenderFn(
 }
 
 function areAdditionalFieldsRenderFn(
-  additionalSignupFields: AdditionalSignupFields
+  additionalSignupFields?: AdditionalSignupFields
 ): additionalSignupFields is AdditionalSignupFieldRenderFn {
   return typeof additionalSignupFields === 'function'
 }

waspc/data/Generator/templates/sdk/wasp/auth/login.ts

@@ -9,6 +9,6 @@ export default async function login(username: string, password: string): Promise
 
     await initSession(response.data.sessionId)
   } catch (error) {
-    handleApiError(error)
+    throw handleApiError(error)
   }
 }

waspc/data/Generator/templates/sdk/wasp/auth/session.ts

@@ -6,7 +6,7 @@ import { type AuthUserData } from '../server/auth/user.js';
 
 import { auth } from "./lucia.js";
 import type { Session } from "lucia";
-import { throwInvalidCredentialsError } from "./utils.js";
+import { createInvalidCredentialsError } from "./utils.js";
 
 import { prisma } from 'wasp/server';
 import { createAuthUserData } from "../server/auth/user.js";
@@ -66,7 +66,7 @@ async function getAuthUserData(userId: {= userEntityUpper =}['id']): Promise<Aut
     })
 
   if (!user) {
-    throwInvalidCredentialsError()
+    throw createInvalidCredentialsError()
   }
 
   return createAuthUserData(user);

waspc/data/Generator/templates/sdk/wasp/auth/signup.ts

@@ -5,6 +5,6 @@ export default async function signup(userFields: { username: string; password: s
   try {
     await api.post('{= signupPath =}', userFields)
   } catch (error) {
-    handleApiError(error)
+    throw handleApiError(error)
   }
 }