Apply some new clippy suggestions (#1549)

apply some clippy suggestions

Author: Robbepop

crates/collections/src/arena/dedup.rs

@@ -64,13 +64,13 @@ impl<Idx, T> DedupArena<Idx, T> {
 
     /// Returns an iterator over the shared reference of the [`Arena`] entities.
     #[inline]
-    pub fn iter(&self) -> Iter<Idx, T> {
+    pub fn iter(&self) -> Iter<'_, Idx, T> {
         self.entities.iter()
     }
 
     /// Returns an iterator over the exclusive reference of the [`Arena`] entities.
     #[inline]
-    pub fn iter_mut(&mut self) -> IterMut<Idx, T> {
+    pub fn iter_mut(&mut self) -> IterMut<'_, Idx, T> {
         self.entities.iter_mut()
     }
 }

crates/collections/src/arena/mod.rs

@@ -86,7 +86,7 @@ impl<Idx, T> Arena<Idx, T> {
 
     /// Returns an iterator over the shared reference of the arena entities.
     #[inline]
-    pub fn iter(&self) -> Iter<Idx, T> {
+    pub fn iter(&self) -> Iter<'_, Idx, T> {
         Iter {
             iter: self.entities.iter().enumerate(),
             marker: PhantomData,
@@ -95,7 +95,7 @@ impl<Idx, T> Arena<Idx, T> {
 
     /// Returns an iterator over the exclusive reference of the arena entities.
     #[inline]
-    pub fn iter_mut(&mut self) -> IterMut<Idx, T> {
+    pub fn iter_mut(&mut self) -> IterMut<'_, Idx, T> {
         IterMut {
             iter: self.entities.iter_mut().enumerate(),
             marker: PhantomData,

crates/core/src/table/element.rs

@@ -30,7 +30,7 @@ impl ElementSegment {
     }
 
     /// Returns `self` as [`ElementSegmentRef`].
-    pub fn as_ref(&self) -> ElementSegmentRef {
+    pub fn as_ref(&self) -> ElementSegmentRef<'_> {
         ElementSegmentRef::from(self)
     }
 

crates/wasmi/src/engine/code_map.rs

@@ -310,7 +310,7 @@ impl CodeMap {
 
     /// Returns the [`CompiledFuncRef`] of `func` if possible, otherwise returns `None`.
     #[inline]
-    fn get_compiled(&self, func: EngineFunc) -> Option<CompiledFuncRef> {
+    fn get_compiled(&self, func: EngineFunc) -> Option<CompiledFuncRef<'_>> {
         let funcs = self.funcs.lock();
         let Some(entity) = funcs.get(func) else {
             // Safety: this is just called internally with function indices
@@ -396,7 +396,7 @@ impl CodeMap {
     /// - If `ctx` ran out of fuel in case fuel consumption is enabled.
     #[cold]
     #[inline(never)]
-    fn wait_for_compilation(&self, func: EngineFunc) -> Result<CompiledFuncRef, Error> {
+    fn wait_for_compilation(&self, func: EngineFunc) -> Result<CompiledFuncRef<'_>, Error> {
         'wait: loop {
             let funcs = self.funcs.lock();
             let Some(entity) = funcs.get(func) else {
@@ -470,7 +470,7 @@ impl FuncEntity {
     ///
     /// Returns `None` if the [`FuncEntity`] has not yet been compiled.
     #[inline]
-    pub fn get_compiled(&self) -> Option<CompiledFuncRef> {
+    pub fn get_compiled(&self) -> Option<CompiledFuncRef<'_>> {
         match self {
             FuncEntity::Compiled(func) => Some(func.into()),
             _ => None,
@@ -509,7 +509,7 @@ impl FuncEntity {
     ///
     /// If `func` has already been initialized.
     #[inline]
-    pub fn set_compiled(&mut self, entity: CompiledFuncEntity) -> CompiledFuncRef {
+    pub fn set_compiled(&mut self, entity: CompiledFuncEntity) -> CompiledFuncRef<'_> {
         assert!(matches!(self, Self::Compiling));
         *self = Self::Compiled(entity);
         let Self::Compiled(entity) = self else {

crates/wasmi/src/engine/translator/func/control_stack.rs

@@ -98,7 +98,7 @@ impl ControlStack {
     /// Pops the top-most [`Provider`] slice of an `else` branch of an [`IfControlFrame`] to the [`ControlStack`].
     ///
     /// [`IfControlFrame`]: super::control_frame::IfControlFrame
-    pub fn pop_else_providers(&mut self) -> Drain<Provider<TypedVal>> {
+    pub fn pop_else_providers(&mut self) -> Drain<'_, Provider<TypedVal>> {
         self.else_providers
             .pop()
             .expect("missing else providers for `else` branch")
@@ -133,7 +133,7 @@ impl ControlStack {
     }
 
     /// Acquires the target [`ControlFrame`] at the given relative `depth`.
-    pub fn acquire_target(&mut self, depth: u32) -> AcquiredTarget {
+    pub fn acquire_target(&mut self, depth: u32) -> AcquiredTarget<'_> {
         let is_root = self.is_root(depth);
         let frame = self.nth_back_mut(depth);
         if is_root {

crates/wasmi/src/engine/translator/func/instr_encoder.rs

@@ -139,7 +139,7 @@ impl InstrSequence {
     /// # Note
     ///
     /// The [`InstrSequence`] will be in an empty state after this operation.
-    pub fn drain(&mut self) -> Drain<Instruction> {
+    pub fn drain(&mut self) -> Drain<'_, Instruction> {
         self.instrs.drain(..)
     }
 
@@ -191,7 +191,7 @@ impl InstrEncoder {
     /// # Note
     ///
     /// The [`InstrEncoder`] will be in an empty state after this operation.
-    pub fn drain_instrs(&mut self) -> Drain<Instruction> {
+    pub fn drain_instrs(&mut self) -> Drain<'_, Instruction> {
         self.instrs.drain()
     }
 

crates/wasmi/src/engine/translator/func/provider.rs

@@ -123,7 +123,7 @@ impl<T> ProviderSliceStack<T> {
     }
 
     /// Pops the top-most [`Reg`] slice from the [`ProviderSliceStack`] and returns it.
-    pub fn pop(&mut self) -> Option<Drain<Provider<T>>> {
+    pub fn pop(&mut self) -> Option<Drain<'_, Provider<T>>> {
         let end = self.ends.pop()?;
         let start = self.ends.last().copied().unwrap_or(0);
         Some(self.providers.drain(start..end))

crates/wasmi/src/engine/translator/func/stack/consts.rs

@@ -97,7 +97,7 @@ impl FuncLocalConsts {
     /// # Note
     ///
     /// The function local constant values are yielded in their allocation order.
-    pub fn iter(&self) -> FuncLocalConstsIter {
+    pub fn iter(&self) -> FuncLocalConstsIter<'_> {
         FuncLocalConstsIter::new(self)
     }
 }

crates/wasmi/src/engine/translator/func/stack/mod.rs

@@ -184,7 +184,7 @@ impl ValueStack {
     /// and accessed via negative [`Reg`] index where the 0 index is referring
     /// to the first function local and the -1 index is referring to the first
     /// allocated function local constant value.
-    pub fn func_local_consts(&self) -> FuncLocalConstsIter {
+    pub fn func_local_consts(&self) -> FuncLocalConstsIter<'_> {
         self.consts.iter()
     }
 

crates/wasmi/src/engine/translator/labels.rs

@@ -174,7 +174,7 @@ impl LabelRegistry {
     /// # Panics
     ///
     /// If used before all used branching labels have been pinned.
-    pub fn resolved_users(&self) -> ResolvedUserIter {
+    pub fn resolved_users(&self) -> ResolvedUserIter<'_> {
         ResolvedUserIter {
             users: self.users.iter(),
             registry: self,