Merge pull request #183 from ahmedtadde/feat/simplify-adding-scaler-for-scale-manager

Refactor manifest upgrade for more efficient scaler computation

Author: thomastaylor312

src/scaler/manager.rs

@@ -248,8 +248,11 @@ where
     /// This only constructs the scalers and doesn't reconcile. The returned [`Scalers`] type can be
     /// used to set this model to backoff mode
     #[instrument(level = "trace", skip_all, fields(name = %manifest.metadata.name, lattice_id = %self.lattice_id))]
-    pub async fn add_scalers<'a>(&'a self, manifest: &'a Manifest) -> Result<Scalers> {
-        let scalers = self.scalers_for_manifest(manifest);
+    pub async fn add_scalers<'a>(
+        &'a self,
+        manifest: &'a Manifest,
+        scalers: ScalerList,
+    ) -> Result<Scalers> {
         self.add_raw_scalers(&manifest.metadata.name, scalers).await;
         let notification = serde_json::to_vec(&Notifications::CreateScalers(manifest.to_owned()))?;
         self.client

src/workers/event.rs

@@ -793,8 +793,7 @@ where
         // redelivered. When it is, the ones that succeeded will be in backoff mode and the ones
         // that failed will be retried.
 
-        // TODO: inefficient to compute scalers twice, consider refactoring
-        let scalers = self.scalers.add_scalers(&data.manifest).await?;
+        let scalers = self.scalers.add_scalers(&data.manifest, scalers).await?;
 
         let (commands, res) = get_commands_and_result(
             scalers.iter().map(|s| s.reconcile()),