onSaved needs workaround to work

[w7tf]

Currently onSaved is done the following way:

onSaved: ({ saved }) => {
      const post = store$.posts
        .filter((post) => saved.id === post.id.get())[0]
        .get();
      post.updatedAt = saved.updatedAt; // no set to not retrigger any crud ops
      post.createdAt = saved.createdAt; // no set to not retrigger any crud ops
    },

[jmeistrich]

The observable should be updated automatically with the saved value from create and update, as long as those return with the updated values (which it seems like they do). So this shouldn't be necessary at all. Are they not updating automatically?

[w7tf]

The observable should be updated automatically with the saved value from create and update, as long as those return with the updated values (which it seems like they do). So this shouldn't be necessary at all. Are they not updating automatically?

They are updating automatically if as is set to object, it does not work if as is set to array

[jmeistrich]

Oh gotcha! Ok I've reproduced it in a test and will fix it.

For what it's worth I'd recommend probably not using as: 'array'. It's usually much easier to update items in an object or Map by id, whereas with an array you end up running find a lot.

[w7tf]

Oh gotcha! Ok I've reproduced it in a test and will fix it.

For what it's worth I'd recommend probably not using as: 'array'. It's usually much easier to update items in an object or Map by id, whereas with an array you end up running find a lot.

Yeah good input thanks! I forgot to think about O-complexity when I set it to use as array. Apart from the Object.values(obj) syntax when listing the whole state it makes much more sense to as object. Will refactor the store to use as object.

[jmeistrich]

Ok cool, sounds good! I have a fix coming in the next patch but I won't rush it since you don't need it urgently :)