Skip to content

Commit 57eb5e9

Browse files
jgrahamOrKoN
andauthored
Fix some small problems with set window rect changes (#1832)
* Fix some small problems with set window rect changes * Restore handling both missing and null values for parameters. * Fix some grammar errors. * Apply suggestions from code review --------- Co-authored-by: Alex Rudenko <OrKoN@users.noreply.github.com>
1 parent bb939cc commit 57eb5e9

File tree

1 file changed

+26
-15
lines changed

1 file changed

+26
-15
lines changed

index.html

Lines changed: 26 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -4046,28 +4046,39 @@ <h4><dfn>Set Window Rect</dfn></h4>
40464046
<a>getting a property</a> named "<code>width</code>"
40474047
from <var>parameters</var></a>.
40484048

4049+
<li><p>If <var>width</var> is <a>undefined</a>, let <var>width</var>
4050+
be null.
4051+
40494052
<li><p>Let <var>height</var> be the result of
40504053
<a>getting a property</a> named "<code>height</code>"
40514054
from <var>parameters</var>.
40524055

4056+
<li><p>If <var>height</var> is <a>undefined</a>, let <var>height</var>
4057+
be null.
4058+
40534059
<li><p>Let <var>x</var> be the result of <a>getting a property</a>
40544060
named "<code>x</code>" from <var>parameters</var>.
40554061

4062+
<li><p>If <var>x</var> is <a>undefined</a>, let <var>x</var> be null.
4063+
40564064
<li><p>Let <var>y</var> be the result of <a>getting a property</a>
40574065
named "<code>y</code>" from <var>parameters</var>.
40584066

4059-
<li><p>If <var>width</var> or <var>height</var> is neither <a>undefined</a>
4060-
nor a <a>Number</a> from 0 to 2<sup>31</sup> − 1,
4061-
return <a>error</a> with <a>error code</a> <a>invalid argument</a>.
4067+
<li><p>If <var>y</var> is <a>undefined</a>, let <var>y</var> be null.
40624068

4063-
<li><p>If <var>x</var> or <var>y</var> is neither <a>undefined</a>
4064-
nor a <a>Number</a> from −(2<sup>31</sup>) to 2<sup>31</sup> − 1,
4069+
<li><p>If <var>width</var> or <var>height</var> is neither null, nor
4070+
a <a>Number</a> from 0 to 2<sup>31</sup> − 1, return <a>error</a>
4071+
with <a>error code</a> <a>invalid argument</a>.
4072+
4073+
<li><p>If <var>x</var> or <var>y</var> is neither null, nor
4074+
a <a>Number</a> from −(2<sup>31</sup>) to 2<sup>31</sup> − 1,
40654075
return <a>error</a> with <a>error code</a> <a>invalid argument</a>.
40664076

40674077
<li><p>If the <a>remote end</a> does not support
40684078
the <a>Set Window Rect</a> <a>command</a> for
4069-
<var>session</var>&apos;s <a>current top-level browsing context</a> for any reason,
4070-
return <a>error</a> with <a>error code</a> <a>unsupported operation</a>.
4079+
<var>session</var>&apos;s <a>current top-level browsing context</a>
4080+
for any reason, return <a>error</a> with <a>error
4081+
code</a> <a>unsupported operation</a>.
40714082

40724083
<p class="note">In case the <a>Set Window Rect</a> command is
40734084
partially supported (i.e. some combinations of arguments are
@@ -4092,12 +4103,12 @@ <h4><dfn>Set Window Rect</dfn></h4>
40924103
of <var>window</var>:
40934104

40944105
<ol>
4095-
<li><p>If <var>width</var> is not <a>undefined</a>, set the width,
4106+
<li><p>If <var>width</var> is not null, set the width,
40964107
in <a>CSS pixels</a>, of <var>window</var>, including
40974108
any <a>browser chrome</a> and externally drawn window decorations,
40984109
to a value that is as close as possible to <var>width</var>.
40994110

4100-
<li><p>If <var>height</var> is not <a>undefined</a>, set the height,
4111+
<li><p>If <var>height</var> is not null, set the height,
41014112
in <a>CSS pixels</a>, of <var>window</var>, including
41024113
any <a>browser chrome</a> and externally drawn window decorations,
41034114
to a value that is as close as possible to <var>height</var>.
@@ -4127,13 +4138,13 @@ <h4><dfn>Set Window Rect</dfn></h4>
41274138
<li><p>If the implementation is able to set the position of <var>window</var>:
41284139

41294140
<ol>
4130-
<li><p>If <var>x</var> is not <a>undefined</a>, run specific
4131-
steps set the x-coordinate of the left edge of <var>window</var>
4132-
to a value that is as close as possible to <var>x</var>.
4141+
<li><p>If <var>x</var> is not null, set the x-coordinate of the
4142+
left edge of <var>window</var> to a value that is as close as
4143+
possible to <var>x</var>.
41334144

4134-
<li><p>If <var>y</var> is not <a>undefined</a>, run specific
4135-
steps set the y-coordinate of the top edge of <var>window</var> to
4136-
a value that is as close as possible to <var>y</var>.
4145+
<li><p>If <var>y</var> is not null, set the y-coordinate of the top
4146+
edge of <var>window</var> to a value that is as close as possible
4147+
to <var>y</var>.
41374148
</ol>
41384149

41394150
<aside class=note>

0 commit comments

Comments
 (0)