Skip to content

xml comments break xml parsing #6

@velcrome

Description

@velcrome

The following vpack will not download ZeroMQ, because of the commented dependency.

It will process nicely without the comment, so I think this is a bug.

<vpack>
  <meta>
    <name>vvvv-ZeroMQ</name>
    <source>https://github.com/velcrome/vvvv-ZeroMQ</source>
    <author>velcrome</author>
    <dependencies>
      <!--dependency>
        <name>vvvv-Message</name>
        <source>vpms://raw.githubusercontent.com/velcrome/vvvv-Message/develop/copy/vvvv-Message.vpack</source>
      </dependency-->
    </dependencies>
  </meta>
  <install>
    Download(
      "https://github.com/velcrome/vvvv-ZeroMQ/releases/download/0.5.1/vvvv-ZeroMQ.zip",
      VPM.TempDir + "\\vvvv-ZeroMQ.zip"
    );
    Extract(VPM.TempDir + "\\vvvv-ZeroMQ.zip", Pack.TempDir + "\\extract");
	  CopyDir(
	    Pack.TempDir + "\\extract",
	    VVVV.Dir + "\\packs\\vvvv-ZeroMQ"
	  );
  </install>
</vpack>

Note that this behaviour is recursive, if there is a similar error in the dependency's vpm

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions