Skip to content

Commit 7c11984

Browse files
committed
fix unittest issue
1 parent 0ebea1e commit 7c11984

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

tests/initial_setup.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ wget -O metabase.jar -q https://downloads.metabase.com/v$MB_VERSION/metabase.jar
2828
# starting metabase jar locally
2929
java -jar metabase.jar > logs 2>&1 &
3030

31-
# waiting 45 seconds for the initialization to complete
32-
sleep 45
31+
# waiting 60 seconds for the initialization to complete
32+
sleep 60
3333

3434
# checking whether the metabase initialization has completed. If not, wait another 45 seconds
3535
success='False'
@@ -102,7 +102,7 @@ json='{
102102
"dataset_query":{
103103
"type":"native",
104104
"native":{
105-
"query":"select *\nfrom test_table\nwhere 1 = 1 \n[[ and {{test_filter}} ]]\n",
105+
"query":"select *\nfrom test_table2\nwhere 1 = 1 \n[[ and {{test_filter}} ]]\n",
106106
"template-tags":{
107107
"test_filter":{
108108
"name":"test_filter",

tests/test_metabase_api.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -265,10 +265,10 @@ def test_get_card_data(self):
265265
csv_data = 'col1,col2\nrow1 cell1,1\n,2\nrow3 cell1,\n,\nrow5 cell1,5\n'
266266
self.assertEqual(res, csv_data)
267267

268-
# # filtered data
269-
# res = mb.get_card_data(card_id=2, parameters=[{"type":"string/=","value":['row1 cell1', 'row3 cell1'],"target":["dimension",["template-tag","test_filter"]]}])
270-
# filtered_data = [{'col1': 'row1 cell1', 'col2': 1}, {'col1': 'row3 cell1', 'col2': None}]
271-
# self.assertEqual(res, filtered_data)
268+
# filtered data
269+
res = mb.get_card_data(card_id=2, parameters=[{"type":"string/=","value":['row1 cell1', 'row3 cell1'],"target":["dimension",["template-tag","test_filter"]]}])
270+
filtered_data = [{'col1': 'row1 cell1', 'col2': '1'}, {'col1': 'row3 cell1', 'col2': None}]
271+
self.assertEqual(res, filtered_data)
272272

273273

274274

0 commit comments

Comments
 (0)