Incompatible types between liquidjs-lib and @vulpemventures/secp256k1-zkp

[bordalix]

Marina has the following dependency on package.json:

"@vulpemventures/secp256k1-zkp": "^3.1.0",

https://github.com/vulpemventures/marina/blob/master/package.json#L26

On yarn.lock is hardcoded to 3.1.0

https://github.com/vulpemventures/marina/blob/master/yarn.lock#L1291

If I remove it from yarn.lock and run yarn, it will update to 3.2.1

Now running yarn start generates the following errors:

ERROR in /Users/bordalix/WIP/Vulpem/vulpemventures/marina/src/application/account.ts
./src/application/account.ts 157:56-62
[tsl] ERROR in /Users/bordalix/WIP/Vulpem/vulpemventures/marina/src/application/account.ts(157,57)
      TS2345: Argument of type 'Secp256k1ZKP' is not assignable to parameter of type 'Secp256k1Interface'.
  The types returned by 'ecc.privateAdd(...)' are incompatible between these types.
    Type 'Uint8Array | null' is not assignable to type 'Uint8Array'.
      Type 'null' is not assignable to type 'Uint8Array'.
 @ ./src/background/background-script.ts 14:0-56 65:30-51

ERROR in /Users/bordalix/WIP/Vulpem/vulpemventures/marina/src/application/account.ts
./src/application/account.ts 214:67-73
[tsl] ERROR in /Users/bordalix/WIP/Vulpem/vulpemventures/marina/src/application/account.ts(214,68)
      TS2345: Argument of type 'Secp256k1ZKP' is not assignable to parameter of type 'Secp256k1Interface'.
 @ ./src/background/background-script.ts 14:0-56 65:30-51

ERROR in /Users/bordalix/WIP/Vulpem/vulpemventures/marina/src/application/signer.ts
./src/application/signer.ts 103:79-82
[tsl] ERROR in /Users/bordalix/WIP/Vulpem/vulpemventures/marina/src/application/signer.ts(103,80)
      TS2345: Argument of type 'Secp256k1ZKP' is not assignable to parameter of type 'Secp256k1Interface'.
 @ ./src/extension/popups/spend.tsx 18:0-57 66:33-59
 @ ./src/extension/routes/index.tsx 6:0-43 51:3567-3579
 @ ./src/extension/app.tsx 7:0-30 9:194-200
 @ ./src/extension/index.tsx 4:0-24 14:17-20

ERROR in /Users/bordalix/WIP/Vulpem/vulpemventures/marina/src/pkg/boltz.ts
./src/pkg/boltz.ts 27:14-17
[tsl] ERROR in /Users/bordalix/WIP/Vulpem/vulpemventures/marina/src/pkg/boltz.ts(27,15)
      TS2614: Module '"@vulpemventures/secp256k1-zkp"' has no exported member 'ZKP'. Did you mean to use 'import ZKP from "@vulpemventures/secp256k1-zkp"' instead?

In fact, types are incompatible:

https://github.com/vulpemventures/liquidjs-lib/blob/8fd2b10e31f028c0f6324f6b246f01e22e66c59e/src/secp256k1-zkp.d.ts#L3

vs

https://github.com/vulpemventures/secp256k1-zkp/blob/master/src/lib/interface.ts#L5

This was introduced in this commit:

da47b5b#diff-4f27e27e38907bb83f71adec1da63604d9bf8be787d44e4bc87cd08dc444ce61R5