Skip to content

Commit f61b820

Browse files
authored
Merge pull request #5260 from hotwax/typo/documentation
[Docs] Fixed some typos
2 parents b740d77 + bde31a8 commit f61b820

File tree

11 files changed

+74
-69
lines changed

11 files changed

+74
-69
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8+
## [1.13.0] - UNRELEASED
9+
10+
### Fixed
11+
- Fixed some typo in docs (#5071)
12+
813
## [1.12.2] - 2020.07.28
914

1015
### Added

docs/guide/cookbook/checklist.md

Lines changed: 15 additions & 15 deletions
Large diffs are not rendered by default.

docs/guide/cookbook/setup.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,7 @@ This looks like by and large the same with *Vue Storefront API* with a few chang
435435
`app` service describes options for *Vue Storefront* frontend application.
436436
- `network_mode` allows you to modify values for `--network` option of docker client. `host` option allows your designated container to open to host network. For example, if you bind your container in host's `80` port, then the container will be accessible at host's `<IP address>:80` from the internet. In other words, the container is not isolated. [more info](https://docs.docker.com/network/host/)
437437

438-
If you take a closer look inside `Dockerfile`s, you will notice they install all the dependencies of the project from `package.json` not to mention required OS features including `git`, `wget` and certificates. You don't have to worry what to do because we made it do for you.
438+
If you take a closer look inside `Dockerfile's`, you will notice they install all the dependencies of the project from `package.json` not to mention required OS features including `git`, `wget` and certificates. You don't have to worry what to do because we made it do for you.
439439
440440
Next, you might want to import your goods data. Please jump to [Data imports](./data-import.md) if you don't want to stop.
441441

docs/guide/core-themes/core-components.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,15 @@
44

55
In Vue Storefront there are two types of components:
66

7-
- In Vue Storefront there are two types of components:
8-
9-
- **Core components:** In core components, we implemented all basic business logic for an eCommerce shop, so you don't need to write it from scratch by yourself. You can make use of them in your themes, where all you need to do is styling and creating the HTML markup. Every core component provides an interface to interact with. This interface can be extended or overwritten in your theme if you need to. Core components should be injected to themes as mixins.They contain only business logic—HTML markup and styling should be done in themes. You can usually find core components inside the `components` folder of every module.
7+
- **Core components:** In core components, we implemented all the basic business logic for an eCommerce shop, so you don't need to write it from scratch by yourself. You can make use of them in your themes, where all you need to do is styling and creating the HTML markup. Every core component provides an interface to interact with. This interface can be extended or overwritten in your theme if you need to. Core components should be injected to themes as mixins.They contain only business logic—HTML markup and styling should be done in themes. You can usually find core components inside the `components` folder of every module.
108

119
- **Theme components:** Theme components are what you really see in the app. They can inherit business logic from core components or be created as theme-specific components. All CSS, HTML, and ui-specific logic should be placed in theme.
1210

1311
## Working with core components
1412

1513
First, **override core components only when you're adding ui-agnostic features to the core.** The correct approach for using core components in your theme is thinking of them as an external API. You can inherit the functionalities and extend them in theme but never change it in core.
1614

17-
**When you're modifying the core component, never change the component's API** (data and methods exposed by the component for themes). Such changes would break the themes using this core component.
15+
**When you're modifying the core component, never change the component's API** (data and methods exposed by the component for themes). Such changes would break the theme using this core component.
1816

1917
## Using core components in your theme
2018

docs/guide/core-themes/layouts.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ This feature can be very useful for non-standard rendering scenarios like:
66

77
- Generating the XML output
88
- Generating the AMPHTML pages
9-
- generating widgets without `<head>` section
9+
- Generating widgets without `<head>` section
1010

1111
## How it works
1212

@@ -188,6 +188,6 @@ Please note that the `context` contains a lot of interesting features you can us
188188

189189
## Output compression
190190

191-
HTML Minifier has been added to Vue Storefront 1.11. To enable this feature please switch the `config.server.useHtmlMinifier`. You can set the specific configuration of the `htmlMinifier` using the `config.server.htmlMinifierOptions`. Read more on the [available configuration](https://www.npmjs.com/package/html-minifier). The minified output is tthen being cached by `SSR Output cache` mechanism.
191+
HTML Minifier has been added to Vue Storefront 1.11. To enable this feature please switch the `config.server.useHtmlMinifier`. You can set the specific configuration of the `htmlMinifier` using the `config.server.htmlMinifierOptions`. Read more on the [available configuration](https://www.npmjs.com/package/html-minifier). The minified output is then being cached by `SSR Output cache` mechanism.
192192

193-
Output compression has been also enabled (if the `src/modules/server.ts` contains the `compression` module on the list). By default it works just for produdction builds. It uses the `gzip` compression by default. [Read more about the `compression` module](https://www.npmjs.com/package/compression) that we're using for this implementation.
193+
Output compression has been also enabled (if the `src/modules/server.ts` contains the `compression` module on the list). By default it works just for production builds. It uses the `gzip` compression by default. [Read more about the `compression` module](https://www.npmjs.com/package/compression) that we're using for this implementation.

docs/guide/core-themes/service-workers.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ The service-worker source code for `vue-storefront` is pre-compiled with Babel p
1313

1414
After changing anything in `{themename}/service-worker/index.js`, despite you're in `yarn dev` auto reloading mode, you need to do two things:
1515

16-
1.Recompile app (which regenerates service-worker):
16+
1. Recompile app (which regenerates service-worker):
1717
`yarn build`
1818

1919
2. Reload Service Worker in Dev Tools (in Chrome, just click **"Unregister"** and reload the page, and a new Service Worker will be installed).

docs/guide/data-resolvers/introduction.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33
## What are the data resolvers?
44

55
The `data resolvers` are the way of manage the network/api calls and split them from the rest of application. All of available `data resolvers` you can find in the `core/data-resolver` directory.
6-
If you want to trigger a network calls, you should create a new `data resolver`, and import it in the place where it's needed.
6+
If you want to trigger a network call, you should create a new `data resolver`, and import it in the place where it's needed.
77

88
## How to create a data resolver
9-
First of all, please create a types for it under the namespace `DataResolver`, then just create a new data resolver like this example below:
9+
First of all, please create a type for it under the namespace `DataResolver`, then just create a new data resolver like this example below:
1010

1111

1212
```js

docs/guide/data-resolvers/user-service.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Registering the new user by given user data (`customer`) and `password`.
1616

1717
#### `updateProfile: (userProfile: UserProfile) => Promise<Task>`
1818

19-
It updates the the current logged user profile (`userProfile`).
19+
It updates the current logged user profile (`userProfile`).
2020

2121
#### `getProfile: () => Promise<Task>`
2222

docs/guide/general/introduction.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ We managed to do this by making extensive use of the browser cache. 
9595
- **For the static assets** (only prod) we use the [sw-precache](https://github.com/GoogleChromeLabs/sw-precache) plugin (config can be found in `core/build/webpack.prod.sw.config.js` ). They are cached in Service Worker and can be inspected under the `Application/Cache Storage` tab of your Developer Tools.
9696

9797
![cache](https://cdn-images-1.medium.com/max/1200/1*BHVzt7oCIxcM3bNPZriKmw.png)
98-
*Here you can find cached static assets. Please notice that Service Worker works only in production mode.*
98+
*Here you can find cached static assets.*
9999

100100
:::warning
101101
Please note that Service Worker works only in production mode.
@@ -116,7 +116,7 @@ You may not believe me but this is all you need to know to start working with Vu
116116
- [Project structure explained](https://docs.vuestorefront.io/guide/basics/project-structure.html)
117117
- [Configuration file explained](https://docs.vuestorefront.io/guide/basics/configuration.html)
118118
- [Extending Vue Storefront](https://docs.vuestorefront.io/guide/extensions/introduction.html)
119-
- [How to contribute](https://docs.vuestorefront.io/guide/basics/contributing.html#branches)
119+
- [How to contribute](https://docs.vuestorefront.io/guide/basics/contributing.html#how-to-contribute)
120120

121121
## Video with training
122122
You can also watch a video recording from 4th Vue Storefront hackathon with free introduction training

docs/guide/integrations/multistore.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ As you can see, it's just an **IT** or **DE** store code that is added to the ba
6161
In the result, you should get:
6262

6363
- _vue_storefront_catalog_it_ - populated with the "it" store data
64-
- _vue_storefront_catalog_de_ - populated with the "it" store data
64+
- _vue_storefront_catalog_de_ - populated with the "de" store data
6565
- _vue_storefront_catalog_ - populated with the "default" store data
6666

6767
Then, to use these indices in Vue Storefront, you should index the database schema using the `vue-storefront-api` db tool (use only if using mage2vuestorefront!):
@@ -190,7 +190,7 @@ By default, the language / store is switched by the URL prefix:
190190

191191
- `http://localhost:3000` is for the default store
192192
- `http://localhost:3000/it` will switch the store to the Italian one
193-
- `http://localhost:3000/de` will switch the store to the German one one
193+
- `http://localhost:3000/de` will switch the store to the German one
194194

195195
General URL format is:
196196
`http://localhost:3000/{storeCode}`

0 commit comments

Comments
 (0)