Skip to content

Commit f51ad9e

Browse files
authored
Merge pull request #5484 from vuestorefront/typo-in-docs
fixed some typo in docs
2 parents 63f380b + 9ba4978 commit f51ad9e

File tree

13 files changed

+73
-72
lines changed

13 files changed

+73
-72
lines changed

CHANGELOG.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
3333
move pick allowed modification just before sending data to task managment
3434
add 'beforeUserProfileUpdate' which allows to modify user object before update - gibkigonzo (#4427)
3535
- replace lodash with lodash-es for client files - gibkigonzo (#5019)
36-
- add default personal detail loading on shipment step in checkout when user is logged - (#5040)
37-
- Got rid of inifnity redirect or page-not-found on refresh category/product view
36+
- add default personal detail loading on shipment step in checkout when user is logged - (#5040)
37+
- Got rid of inifnity redirect or page-not-found on refresh category/product view
3838
- Got rid of memory leak related to dynamic config - tomasz-duda (#4768)
3939
- servercart-after-diff event payload - Fifciu (#5365)
40+
- Fix Original Price Calculation typo - @akucharczyk / @lukaszjedrasik (#5472)
4041
### Changed / Improved
4142

4243
- Moved hardcoded fields from omitSelectedVariantFields.ts to config (#4679)

core/modules/catalog/helpers/price/syncProductPrice.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export default function syncProductPrice (product, backProduct) { // TODO: we pr
1212

1313
product.price_tax = product.price_incl_tax - product.price
1414
product.special_price_tax = product.special_price_incl_tax - product.special_price
15-
product.original_price_tax = product.original_price_incl_tax - product.original_trice
15+
product.original_price_tax = product.original_price_incl_tax - product.original_price
1616

1717
if (product.price_incl_tax >= product.original_price_incl_tax) {
1818
product.special_price_incl_tax = 0

docs/guide/basics/configuration.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ Please take a look at the `node-config` docs as the library is open for some oth
1919
:::tip NOTE
2020
Currently, the configuration files are being processed by the webpack during the build process. This means that whenever you apply some configuration changes, you shall rebuild the app, even when using the `yarn dev` mode. This limitation can be solved with the VS 1.4 special config variable. Now the config can be reloaded on the fly with each server request if `config.server.dynamicConfigReload` and `config.server.dynamicConfigReloadWithEachRequest` are set to true. However, in that case, the config is added to `window.INITIAL_STATE` with the responses.
2121

22-
When you using the `config.server.dynamicConfigReload` please remember about `config.server.dynamicConfigExclude` and `config.server.dynamicConfigInclude`.
22+
When you are using the `config.server.dynamicConfigReload` please remember about `config.server.dynamicConfigExclude` and `config.server.dynamicConfigInclude`.
2323
:::
2424

2525
Please find the configuration properties reference below.

docs/guide/cookbook/checklist.md

Lines changed: 15 additions & 15 deletions
Large diffs are not rendered by default.

docs/guide/cookbook/setup.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,7 @@ This looks like by and large the same with *Vue Storefront API* with a few chang
435435
`app` service describes options for *Vue Storefront* frontend application.
436436
- `network_mode` allows you to modify values for `--network` option of docker client. `host` option allows your designated container to open to host network. For example, if you bind your container in host's `80` port, then the container will be accessible at host's `<IP address>:80` from the internet. In other words, the container is not isolated. [more info](https://docs.docker.com/network/host/)
437437

438-
If you take a closer look inside `Dockerfile`s, you will notice they install all the dependencies of the project from `package.json` not to mention required OS features including `git`, `wget` and certificates. You don't have to worry what to do because we made it do for you.
438+
If you take a closer look inside `Dockerfile's`, you will notice they install all the dependencies of the project from `package.json` not to mention required OS features including `git`, `wget` and certificates. You don't have to worry what to do because we made it do for you.
439439
440440
Next, you might want to import your goods data. Please jump to [Data imports](./data-import.md) if you don't want to stop.
441441

docs/guide/core-themes/core-components.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44

55
In Vue Storefront there are two types of components:
66

7-
- In Vue Storefront there are two types of components:
8-
97
- **Core components:** In core components, we implemented all basic business logic for an eCommerce shop, so you don't need to write it from scratch by yourself. You can make use of them in your themes, where all you need to do is styling and creating the HTML markup. Every core component provides an interface to interact with. This interface can be extended or overwritten in your theme if you need to. Core components should be injected to themes as mixins.They contain only business logic—HTML markup and styling should be done in themes. You can usually find core components inside the `components` folder of every module.
108

119
- **Theme components:** Theme components are what you really see in the app. They can inherit business logic from core components or be created as theme-specific components. All CSS, HTML, and ui-specific logic should be placed in theme.
@@ -14,7 +12,7 @@ In Vue Storefront there are two types of components:
1412

1513
First, **override core components only when you're adding ui-agnostic features to the core.** The correct approach for using core components in your theme is thinking of them as an external API. You can inherit the functionalities and extend them in theme but never change it in core.
1614

17-
**When you're modifying the core component, never change the component's API** (data and methods exposed by the component for themes). Such changes would break the themes using this core component.
15+
**When you're modifying the core component, never change the component's API** (data and methods exposed by the component for themes). Such changes would break the theme using this core component.
1816

1917
## Using core components in your theme
2018

docs/guide/core-themes/layouts.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ This feature can be very useful for non-standard rendering scenarios like:
66

77
- Generating the XML output
88
- Generating the AMPHTML pages
9-
- generating widgets without `<head>` section
9+
- Generating widgets without `<head>` section
1010

1111
## How it works
1212

@@ -188,6 +188,6 @@ Please note that the `context` contains a lot of interesting features you can us
188188

189189
## Output compression
190190

191-
HTML Minifier has been added to Vue Storefront 1.11. To enable this feature please switch the `config.server.useHtmlMinifier`. You can set the specific configuration of the `htmlMinifier` using the `config.server.htmlMinifierOptions`. Read more on the [available configuration](https://www.npmjs.com/package/html-minifier). The minified output is tthen being cached by `SSR Output cache` mechanism.
191+
HTML Minifier has been added to Vue Storefront 1.11. To enable this feature please switch the `config.server.useHtmlMinifier`. You can set the specific configuration of the `htmlMinifier` using the `config.server.htmlMinifierOptions`. Read more on the [available configuration](https://www.npmjs.com/package/html-minifier). The minified output is then being cached by `SSR Output cache` mechanism.
192192

193-
Output compression has been also enabled (if the `src/modules/server.ts` contains the `compression` module on the list). By default it works just for produdction builds. It uses the `gzip` compression by default. [Read more about the `compression` module](https://www.npmjs.com/package/compression) that we're using for this implementation.
193+
Output compression has been also enabled (if the `src/modules/server.ts` contains the `compression` module on the list). By default it works just for production builds. It uses the `gzip` compression by default. [Read more about the `compression` module](https://www.npmjs.com/package/compression) that we're using for this implementation.

docs/guide/core-themes/service-workers.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ The service-worker source code for `vue-storefront` is pre-compiled with Babel p
1313

1414
After changing anything in `{themename}/service-worker/index.js`, despite you're in `yarn dev` auto reloading mode, you need to do two things:
1515

16-
1.Recompile app (which regenerates service-worker):
16+
1. Recompile app (which regenerates service-worker):
1717
`yarn build`
1818

1919
2. Reload Service Worker in Dev Tools (in Chrome, just click **"Unregister"** and reload the page, and a new Service Worker will be installed).

docs/guide/data-resolvers/introduction.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33
## What are the data resolvers?
44

55
The `data resolvers` are the way of manage the network/api calls and split them from the rest of application. All of available `data resolvers` you can find in the `core/data-resolver` directory.
6-
If you want to trigger a network calls, you should create a new `data resolver`, and import it in the place where it's needed.
6+
If you want to trigger a network call, you should create a new `data resolver`, and import it in the place where it's needed.
77

88
## How to create a data resolver
9-
First of all, please create a types for it under the namespace `DataResolver`, then just create a new data resolver like this example below:
9+
First of all, please create a type for it under the namespace `DataResolver`, then just create a new data resolver like this example below:
1010

1111

1212
```js

docs/guide/data-resolvers/user-service.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Registering the new user by given user data (`customer`) and `password`.
1616

1717
#### `updateProfile: (userProfile: UserProfile) => Promise<Task>`
1818

19-
It updates the the current logged user profile (`userProfile`).
19+
It updates the current logged user profile (`userProfile`).
2020

2121
#### `getProfile: () => Promise<Task>`
2222

0 commit comments

Comments
 (0)