Skip to content

Commit 340dea0

Browse files
committed
feat: a11y improvements
1 parent 830b907 commit 340dea0

File tree

5 files changed

+21
-6
lines changed

5 files changed

+21
-6
lines changed

src/Toggle.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ declare class Toggle extends Vue {
1414
labelledby?: string;
1515
describedby?: string;
1616
classes?: object;
17+
aria?: object;
1718

1819
$emit(eventName: 'change', e: {originalEvent: Event, value: any}): this;
1920

src/Toggle.vue

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66
:aria-describedby="describedby"
77
:aria-labelledby="labelledby"
88
role="switch"
9-
@keyup.space="handleSpace"
9+
v-bind="aria"
10+
@keypress.space.prevent="handleSpace"
1011
>
1112
<input
1213
v-show="false"
@@ -126,6 +127,11 @@
126127
type: String,
127128
required: false,
128129
},
130+
aria: {
131+
required: false,
132+
type: Object,
133+
default: () => ({}),
134+
},
129135
},
130136
setup(props, context)
131137
{

tests/unit/composables/useKeyboard.spec.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { createToggle, keyup } from 'unit-test-helpers'
1+
import { createToggle, keypress } from 'unit-test-helpers'
22
import { nextTick } from 'vue'
33

44
describe('useKeyboard', () => {
@@ -8,7 +8,7 @@ describe('useKeyboard', () => {
88
value: false,
99
})
1010

11-
keyup(toggle, 'space')
11+
keypress(toggle, 'space')
1212

1313
await nextTick()
1414

@@ -20,7 +20,7 @@ describe('useKeyboard', () => {
2020
value: true,
2121
})
2222

23-
keyup(toggle, 'space')
23+
keypress(toggle, 'space')
2424

2525
await nextTick()
2626

@@ -33,7 +33,7 @@ describe('useKeyboard', () => {
3333
disabled: true
3434
})
3535

36-
keyup(toggle, 'space')
36+
keypress(toggle, 'space')
3737

3838
await nextTick()
3939

@@ -46,7 +46,7 @@ describe('useKeyboard', () => {
4646
disabled: true
4747
})
4848

49-
keyup(toggle, 'space')
49+
keypress(toggle, 'space')
5050

5151
await nextTick()
5252

tests/unit/helpers/vue2.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,4 +79,8 @@ const keyEvent = (event, wrapper, key) => {
7979

8080
export const keyup = (wrapper, key) => {
8181
keyEvent('keyup', wrapper, key)
82+
}
83+
84+
export const keypress = (wrapper, key) => {
85+
keyEvent('keypress', wrapper, key)
8286
}

tests/unit/helpers/vue3.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,4 +77,8 @@ const keyEvent = (event, wrapper, key) => {
7777

7878
export const keyup = (wrapper, key) => {
7979
keyEvent('keyup', wrapper, key)
80+
}
81+
82+
export const keypress = (wrapper, key) => {
83+
keyEvent('keypress', wrapper, key)
8084
}

0 commit comments

Comments
 (0)