Skip to content

Commit 380e4cd

Browse files
tangjinzhoutangjinzhou
committed
perf: some code
1 parent 439d9cf commit 380e4cd

File tree

15 files changed

+552
-221
lines changed

15 files changed

+552
-221
lines changed

‎components/form/__tests__/__snapshots__/demo.test.js.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -545,7 +545,7 @@ exports[`renders ./components/form/demo/validate-other.vue correctly 1`] = `
545545
<div class="ant-row ant-form-item">
546546
<div class="ant-col-6 ant-form-item-label"><label for="slider" title="Slider" class="">Slider</label></div>
547547
<div class="ant-col-14 ant-form-item-control-wrapper">
548-
<div class="ant-form-item-control"><span class="ant-form-item-children"><div class="ant-slider ant-slider-with-marks" data-__meta="[object Object]" data-__field="[object Object]" id="slider"><div class="ant-slider-rail"></div><div class="ant-slider-track" style="left: 0%; width: 0%;"></div><div class="ant-slider-step"><span class="ant-slider-dot ant-slider-dot-active" style="left: 0%;"></span><span class="ant-slider-dot" style="left: 20%;"></span><span class="ant-slider-dot" style="left: 40%;"></span><span class="ant-slider-dot" style="left: 60%;"></span><span class="ant-slider-dot" style="left: 80%;"></span><span class="ant-slider-dot" style="left: 100%;"></span></div>
548+
<div class="ant-form-item-control"><span class="ant-form-item-children"><div tabindex="-1" class="ant-slider ant-slider-with-marks" data-__meta="[object Object]" data-__field="[object Object]" id="slider"><div class="ant-slider-rail"></div><div class="ant-slider-track" style="left: 0%; width: 0%;"></div><div class="ant-slider-step"><span class="ant-slider-dot ant-slider-dot-active" style="left: 0%;"></span><span class="ant-slider-dot" style="left: 20%;"></span><span class="ant-slider-dot" style="left: 40%;"></span><span class="ant-slider-dot" style="left: 60%;"></span><span class="ant-slider-dot" style="left: 80%;"></span><span class="ant-slider-dot" style="left: 100%;"></span></div>
549549
<div role="slider" tabindex="0" aria-valuemin="0" aria-valuemax="100" aria-valuenow="0" class="ant-slider-handle" style="left: 0%;"></div>
550550
<div class="ant-slider-mark"><span class="ant-slider-mark-text ant-slider-mark-text-active" style="width: 18%; margin-left: -9%; left: 0%;">A</span><span class="ant-slider-mark-text" style="width: 18%; margin-left: -9%; left: 20%;">B</span><span class="ant-slider-mark-text" style="width: 18%; margin-left: -9%; left: 40%;">C</span><span class="ant-slider-mark-text" style="width: 18%; margin-left: -9%; left: 60%;">D</span><span class="ant-slider-mark-text" style="width: 18%; margin-left: -9%; left: 80%;">E</span><span class="ant-slider-mark-text" style="width: 18%; margin-left: -9%; left: 100%;">F</span></div>
551551
</div></span>

‎components/grid/__tests__/__snapshots__/demo.test.js.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ exports[`renders ./components/grid/demo/playfround.md correctly 1`] = `
160160
<div id="components-grid-demo-playground">
161161
<div style="margin-bottom: 16px;"><span style="margin-right: 6px;">Gutter (px): </span>
162162
<div style="width: 50%;">
163-
<div class="ant-slider ant-slider-with-marks">
163+
<div tabindex="-1" class="ant-slider ant-slider-with-marks">
164164
<div class="ant-slider-rail"></div>
165165
<div class="ant-slider-track" style="left: 0%; width: 20%;"></div>
166166
<div class="ant-slider-step"><span class="ant-slider-dot ant-slider-dot-active" style="left: 0%;"></span><span class="ant-slider-dot ant-slider-dot-active" style="left: 20%;"></span><span class="ant-slider-dot" style="left: 40%;"></span><span class="ant-slider-dot" style="left: 60%;"></span><span class="ant-slider-dot" style="left: 80%;"></span><span class="ant-slider-dot" style="left: 100%;"></span></div>
@@ -169,7 +169,7 @@ exports[`renders ./components/grid/demo/playfround.md correctly 1`] = `
169169
</div>
170170
</div> <span style="margin-right: 6px;">Column Count:</span>
171171
<div style="width: 50%;">
172-
<div class="ant-slider ant-slider-with-marks">
172+
<div tabindex="-1" class="ant-slider ant-slider-with-marks">
173173
<div class="ant-slider-rail"></div>
174174
<div class="ant-slider-track" style="left: 0%; width: 40%;"></div>
175175
<div class="ant-slider-step"><span class="ant-slider-dot ant-slider-dot-active" style="left: 0%;"></span><span class="ant-slider-dot ant-slider-dot-active" style="left: 20%;"></span><span class="ant-slider-dot ant-slider-dot-active" style="left: 40%;"></span><span class="ant-slider-dot" style="left: 60%;"></span><span class="ant-slider-dot" style="left: 80%;"></span><span class="ant-slider-dot" style="left: 100%;"></span></div>

‎components/modal/Modal.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ const modalProps = (defaultProps = {}) => {
2929
/** 点击模态框右上角叉、取消按钮、Props.maskClosable 值为 true 时的遮罩层或键盘按下 Esc 时的回调*/
3030
// onCancel: (e: React.MouseEvent<any>) => void,
3131
afterClose: PropTypes.func.def(noop),
32-
/** 居中 */
32+
/** 垂直居中 */
3333
centered: PropTypes.bool,
3434
/** 宽度*/
3535
width: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),

‎components/modal/confirm.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@ export default function confirm (config) {
2626
confirmDialogInstance = null
2727
div.parentNode.removeChild(div)
2828
}
29-
const triggerCancel = args && args.length &&
30-
args.some(param => param && param.triggerCancel)
29+
const triggerCancel = args.some(param => param && param.triggerCancel)
3130
if (config.onCancel && triggerCancel) {
3231
config.onCancel(...args)
3332
}

‎components/pagination/Pagination.jsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
import PropTypes from '../_util/vue-types'
33
import VcSelect from '../select'
44
import MiniSelect from './MiniSelect'
5-
import enUS from '../vc-pagination/locale/en_US'
65
import LocaleReceiver from '../locale-provider/LocaleReceiver'
76
import { getOptionProps } from '../_util/props-util'
87
import VcPagination from '../vc-pagination'
@@ -121,7 +120,6 @@ export default {
121120
return (
122121
<LocaleReceiver
123122
componentName='Pagination'
124-
defaultLocale={enUS}
125123
scopedSlots={
126124
{ default: this.renderPagination }
127125
}

‎components/progress/__tests__/__snapshots__/index.test.js.snap

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,18 @@ exports[`Progress render negetive successPercent 2`] = `
5151
</div>
5252
`;
5353

54+
exports[`Progress render normal progress 1`] = `
55+
<div class="ant-progress ant-progress-line ant-progress-status-normal ant-progress-show-info ant-progress-default">
56+
<div>
57+
<div class="ant-progress-outer">
58+
<div class="ant-progress-inner">
59+
<div class="ant-progress-bg" style="width: 0%; height: 8px; border-radius: 100px;"></div>
60+
</div>
61+
</div><span title="0%" class="ant-progress-text">0%</span>
62+
</div>
63+
</div>
64+
`;
65+
5466
exports[`Progress render out-of-range progress 1`] = `
5567
<div class="ant-progress ant-progress-line ant-progress-status-success ant-progress-show-info ant-progress-default">
5668
<div>

‎components/progress/__tests__/index.test.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,4 +98,9 @@ describe('Progress', () => {
9898
expect(wrapper.html()).toMatchSnapshot()
9999
})
100100
})
101+
102+
it('render normal progress', () => {
103+
const wrapper = mount(Progress, { propsData: { status: 'normal' }})
104+
expect(wrapper.html()).toMatchSnapshot()
105+
})
101106
})

‎components/spin/Spin.jsx

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -48,14 +48,6 @@ export default {
4848

4949
}
5050
},
51-
mounted () {
52-
this.$nextTick(() => {
53-
const { spinning, delay } = this
54-
if (shouldDelay(spinning, delay)) {
55-
this.delayTimeout = window.setTimeout(this.delayUpdateSpinning, delay)
56-
}
57-
})
58-
},
5951
updated () {
6052
this.$nextTick(() => {
6153
const { delay, spinning, sSpinning } = this
@@ -150,26 +142,18 @@ export default {
150142
)
151143
const children = this.getChildren()
152144
if (children) {
153-
let animateClassName = prefixCls + '-nested-loading'
154-
if (wrapperClassName) {
155-
animateClassName += ' ' + wrapperClassName
156-
}
157145
const containerClassName = {
158146
[`${prefixCls}-container`]: true,
159147
[`${prefixCls}-blur`]: sSpinning,
160148
}
161149

162150
return (
163-
<transition-group
164-
{...getTransitionProps('fade', { appear: false })}
165-
tag='div'
166-
class={animateClassName}
167-
>
151+
<div {...{ on: this.$listeners }} class={[`${prefixCls}-nested-loading`, wrapperClassName]}>
168152
{sSpinning && <div key='loading'>{spinElement}</div>}
169153
<div class={containerClassName} key='container'>
170154
{children}
171155
</div>
172-
</transition-group>
156+
</div>
173157
)
174158
}
175159
return spinElement

‎components/spin/__tests__/__snapshots__/index.test.js.snap

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
// Jest Snapshot v1, https://goo.gl/fbAQLP
22

33
exports[`Spin should only affect the spin element when set style to a nested <Spin>xx</Spin> 1`] = `
4-
<span tag="div" class="ant-spin-nested-loading" style="background: red;"><div><div class="ant-spin ant-spin-spinning"><span class="ant-spin-dot ant-spin-dot-spin"><i></i><i></i><i></i><i></i></span></div>
4+
<div class="ant-spin-nested-loading" style="background: red;">
5+
<div>
6+
<div class="ant-spin ant-spin-spinning"><span class="ant-spin-dot ant-spin-dot-spin"><i></i><i></i><i></i><i></i></span></div>
7+
</div>
8+
<div class="ant-spin-container ant-spin-blur">
9+
<div>content</div>
10+
</div>
511
</div>
6-
<div class="ant-spin-container ant-spin-blur">
7-
<div>content</div>
8-
</div>
9-
</span>
1012
`;
1113

1214
exports[`Spin should render custom indicator when it's set 1`] = `

‎components/table/__tests__/__snapshots__/Table.filter.test.js.snap

Lines changed: 44 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -11,27 +11,51 @@ exports[`Table.filter renders custom content correctly 1`] = `
1111
`;
1212

1313
exports[`Table.filter renders filter correctly 1`] = `
14-
<div class="ant-table-wrapper"><span tag="div" class="ant-spin-nested-loading"><div class="ant-spin-container"><div class="ant-table ant-table-scroll-position-left ant-table-default"><div class="ant-table-content"><!----><div class="ant-table-body"><table class=""><colgroup><col></colgroup><thead class="ant-table-thead"><tr><th key="name" class="ant-table-column-has-actions ant-table-column-has-filters"><div>Name</div><i title="Filter menu" class="anticon anticon-filter ant-dropdown-trigger"><svg viewBox="64 64 896 896" data-icon="filter" width="1em" height="1em" fill="currentColor" aria-hidden="true" class=""><path d="M349 838c0 17.7 14.2 32 31.8 32h262.4c17.6 0 31.8-14.3 31.8-32V642H349v196zm531.1-684H143.9c-24.5 0-39.8 26.7-27.5 48l221.3 376h348.8l221.3-376c12.1-21.3-3.2-48-27.7-48z"></path></svg></i></th></tr></thead><tbody class="ant-table-tbody"><tr class="ant-table-row ant-table-row-level-0" data-row-key="0"><td class="ant-table-column-has-actions ant-table-column-has-filters"><span class="ant-table-row-indent indent-level-0" style="padding-left: 0px;"></span>
15-
<!---->Jack</td>
16-
</tr>
17-
<tr class="ant-table-row ant-table-row-level-0" data-row-key="1">
18-
<td class="ant-table-column-has-actions ant-table-column-has-filters"><span class="ant-table-row-indent indent-level-0" style="padding-left: 0px;"></span>
19-
<!---->Lucy</td>
20-
</tr>
21-
<tr class="ant-table-row ant-table-row-level-0" data-row-key="2">
22-
<td class="ant-table-column-has-actions ant-table-column-has-filters"><span class="ant-table-row-indent indent-level-0" style="padding-left: 0px;"></span>
23-
<!---->Tom</td>
24-
</tr>
25-
<tr class="ant-table-row ant-table-row-level-0" data-row-key="3">
26-
<td class="ant-table-column-has-actions ant-table-column-has-filters"><span class="ant-table-row-indent indent-level-0" style="padding-left: 0px;"></span>
27-
<!---->Jerry</td>
28-
</tr>
29-
</tbody>
30-
</table>
31-
</div>
32-
</div>
14+
<div class="ant-table-wrapper">
15+
<div class="ant-spin-nested-loading">
16+
<div class="ant-spin-container">
17+
<div class="ant-table ant-table-scroll-position-left ant-table-default">
18+
<div class="ant-table-content">
19+
<!---->
20+
<div class="ant-table-body">
21+
<table class="">
22+
<colgroup>
23+
<col>
24+
</colgroup>
25+
<thead class="ant-table-thead">
26+
<tr>
27+
<th key="name" class="ant-table-column-has-actions ant-table-column-has-filters">
28+
<div>Name</div><i title="Filter menu" class="anticon anticon-filter ant-dropdown-trigger"><svg viewBox="64 64 896 896" data-icon="filter" width="1em" height="1em" fill="currentColor" aria-hidden="true" class="">
29+
<path d="M349 838c0 17.7 14.2 32 31.8 32h262.4c17.6 0 31.8-14.3 31.8-32V642H349v196zm531.1-684H143.9c-24.5 0-39.8 26.7-27.5 48l221.3 376h348.8l221.3-376c12.1-21.3-3.2-48-27.7-48z"></path>
30+
</svg></i>
31+
</th>
32+
</tr>
33+
</thead>
34+
<tbody class="ant-table-tbody">
35+
<tr class="ant-table-row ant-table-row-level-0" data-row-key="0">
36+
<td class="ant-table-column-has-actions ant-table-column-has-filters"><span class="ant-table-row-indent indent-level-0" style="padding-left: 0px;"></span>
37+
<!---->Jack</td>
38+
</tr>
39+
<tr class="ant-table-row ant-table-row-level-0" data-row-key="1">
40+
<td class="ant-table-column-has-actions ant-table-column-has-filters"><span class="ant-table-row-indent indent-level-0" style="padding-left: 0px;"></span>
41+
<!---->Lucy</td>
42+
</tr>
43+
<tr class="ant-table-row ant-table-row-level-0" data-row-key="2">
44+
<td class="ant-table-column-has-actions ant-table-column-has-filters"><span class="ant-table-row-indent indent-level-0" style="padding-left: 0px;"></span>
45+
<!---->Tom</td>
46+
</tr>
47+
<tr class="ant-table-row ant-table-row-level-0" data-row-key="3">
48+
<td class="ant-table-column-has-actions ant-table-column-has-filters"><span class="ant-table-row-indent indent-level-0" style="padding-left: 0px;"></span>
49+
<!---->Jerry</td>
50+
</tr>
51+
</tbody>
52+
</table>
53+
</div>
54+
</div>
55+
</div>
56+
</div>
57+
</div>
3358
</div>
34-
</div></span></div>
3559
`;
3660
3761
exports[`Table.filter renders menu correctly 1`] = `

0 commit comments

Comments
 (0)