From f99d48d01e30e9dff905f73528dfd8cd5e0746c8 Mon Sep 17 00:00:00 2001 From: Kenyon Ralph Date: Sat, 27 Sep 2025 23:53:22 -0700 Subject: [PATCH] init.pp: remove useless exec with default title Per the docs, the special value `default` sets default attribute values for other resource bodies in the same expression. There are no resources in this expression so it doesn't do anything. This was probably intended to be a "legacy-style default, but the style guide says to avoid these anyway. --- REFERENCE.md | 4 ---- manifests/init.pp | 6 ------ 2 files changed, 10 deletions(-) diff --git a/REFERENCE.md b/REFERENCE.md index f5d739e2..85da05a1 100644 --- a/REFERENCE.md +++ b/REFERENCE.md @@ -180,12 +180,8 @@ Default value: `true` ##### `umask` -Data type: `Optional[Python::Umask]` - The default umask for invoked exec calls. -Default value: `undef` - ##### `manage_gunicorn` manage the state for package gunicorn diff --git a/manifests/init.pp b/manifests/init.pp index 3f5ac23f..31061daf 100644 --- a/manifests/init.pp +++ b/manifests/init.pp @@ -62,7 +62,6 @@ Stdlib::Httpurl $anaconda_installer_url = 'https://repo.anaconda.com/archive/Anaconda3-5.2.0-Linux-x86_64.sh', Stdlib::Absolutepath $anaconda_install_path = '/opt/python', Boolean $manage_scl = true, - Optional[Python::Umask] $umask = undef, ) inherits python::params { $exec_prefix = $provider ? { 'scl' => "/usr/bin/scl enable ${version} -- ", @@ -76,11 +75,6 @@ Class['python::install'] -> Class['python::config'] - # Set default umask. - exec { default: - umask => $umask, - } - # Allow hiera configuration of python resources create_resources('python::pip', $python_pips) create_resources('python::pyvenv', $python_pyvenvs)