Merge pull request #642 from bastelfreak/arch

Implement Arch Linux support

Author: bastelfreak

manifests/init.pp

@@ -38,7 +38,7 @@
 #
 class python (
   Python::Package::Ensure    $ensure                      = $python::params::ensure,
-  Python::Version            $version                     = '3',
+  Python::Version            $version                     = $facts['os']['family'] ? { 'Archlinux' => 'system', default => '3' },
   Python::Package::Ensure    $pip                         = $python::params::pip,
   Python::Package::Ensure    $dev                         = $python::params::dev,
   Python::Package::Ensure    $venv                        = $python::params::venv,

manifests/install.pp

@@ -15,12 +15,13 @@
   }
 
   $pythondev = $facts['os']['family'] ? {
-    'AIX'     => "${python}-devel",
-    'Debian'  => "${python}-dev",
-    'FreeBSD' => undef,
-    'Gentoo'  => undef,
-    'RedHat'  => "${python}-devel",
-    'Suse'    => "${python}-devel",
+    'AIX'       => "${python}-devel",
+    'Debian'    => "${python}-dev",
+    'FreeBSD'   => undef,
+    'Gentoo'    => undef,
+    'Archlinux' => undef,
+    'RedHat'    => "${python}-devel",
+    'Suse'      => "${python}-devel",
   }
 
   if $python::manage_python_package {

manifests/params.pp

@@ -5,7 +5,7 @@
 #
 class python::params {
   # Module compatibility check
-  unless $facts['os']['family'] in ['AIX', 'Debian', 'FreeBSD', 'Gentoo', 'RedHat', 'Suse'] {
+  unless $facts['os']['family'] in ['AIX', 'Debian', 'FreeBSD', 'Gentoo', 'RedHat', 'Suse', 'Archlinux'] {
     fail("Module is not compatible with ${facts['os']['name']}")
   }
 
@@ -16,8 +16,6 @@
   $gunicorn                    = 'absent'
   $manage_gunicorn             = true
   $manage_python_package       = true
-  $manage_venv_package         = true
-  $manage_pip_package          = true
   $provider                    = undef
   $valid_versions              = undef
   $manage_scl                  = true
@@ -48,4 +46,13 @@
     },
     default  => 'gunicorn',
   }
+
+  $manage_pip_package = $facts['os']['family'] ? {
+    'Archlinux' => false,
+    default     => true,
+  }
+  $manage_venv_package = $facts['os']['family'] ? {
+    'Archlinux' => false,
+    default     => true,
+  }
 }

metadata.json

@@ -59,6 +59,9 @@
       "operatingsystemrelease": [
         "11.3"
       ]
+    },
+    {
+      "operatingsystem": "Archlinux"
     }
   ],
   "requirements": [

spec/classes/python_spec.rb

@@ -16,9 +16,18 @@
         it { is_expected.to contain_class('python::params') }
         it { is_expected.to contain_class('python::config') }
         it { is_expected.to contain_package('python') }
-        it { is_expected.to contain_package('pip') }
 
-        it { is_expected.to contain_package('python-venv') } unless facts[:os]['name'] == 'CentOS'
+        if facts[:os]['family'] == 'Archlinux'
+          it { is_expected.not_to contain_package('pip') }
+        else
+          it { is_expected.to contain_package('pip') }
+        end
+
+        if %w[Archlinux CentOS].include?(facts[:os]['name'])
+          it { is_expected.not_to contain_package('python-venv') }
+        else
+          it { is_expected.to contain_package('python-venv') }
+        end
       end
 
       context 'without managing things' do

spec/defines/requirements_spec.rb

@@ -50,12 +50,17 @@
         it { is_expected.to contain_class('python::params') }
         it { is_expected.to contain_class('python') }
         it { is_expected.to contain_exec('python_requirements/requirements.txt') }
-        it { is_expected.to contain_package('pip') }
+
+        if facts[:os]['family'] == 'Archlinux'
+          it { is_expected.not_to contain_package('pip') }
+        else
+          it { is_expected.to contain_package('pip') }
+        end
         it { is_expected.to contain_package('python') }
         it { is_expected.to contain_package('gunicorn') }
         it { is_expected.to contain_file('/requirements.txt').with_owner('root').with_group('root') }
 
-        if %w[FreeBSD Gentoo].include?(facts[:os]['name'])
+        if %w[Archlinux FreeBSD Gentoo].include?(facts[:os]['name'])
           it { is_expected.not_to contain_package('python-dev') }
         else
           it { is_expected.to contain_package('python-dev') }