insecure settings for otlp over http

Author: vodolaz095

tracing/all.go

@@ -5,7 +5,6 @@ import (
 	"fmt"
 
 	"go.opentelemetry.io/otel/attribute"
-	"go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp"
 )
 
 // Config is universal config being used to tune tracing
@@ -79,15 +78,11 @@ func Start(cfg Config, extraAttributes ...attribute.KeyValue) (err error) {
 func StartWithContext(ctx context.Context, cfg Config, extraAttributes ...attribute.KeyValue) (err error) {
 	switch cfg.Protocol {
 	case "otlp_http", "OTLP_HTTP":
-		var opts []otlptracehttp.Option
-		if cfg.Insecure {
-			opts = append(opts, otlptracehttp.WithInsecure())
-		}
 		return ConfigureOTLPoverHTTP(ctx, OTLPoverHTTPConfig{
 			Endpoint:    cfg.Endpoint,
 			Compression: true,
 			Ratio:       cfg.Ratio,
-			Opts:        opts,
+			Insecure:    cfg.Insecure,
 		}, extraAttributes...)
 	case "udp", "UDP":
 		return ConfigureUDP(UDPConfig{

tracing/otlp_over_http.go

@@ -14,6 +14,7 @@ type OTLPoverHTTPConfig struct {
 	Ratio       float64                `yaml:"ratio" validate:"lte=1,gte=0"`
 	Headers     map[string]string      `yaml:"headers"`
 	Opts        []otlptracehttp.Option `yaml:"-"`
+	Insecure    bool                   `yaml:"insecure"`
 }
 
 // ConfigureOTLPoverHTTP fine tunes OTLP HTTP exporter to deliver spans via OTLP over HTTP protocol to collector http endpoint
@@ -28,6 +29,9 @@ func ConfigureOTLPoverHTTP(ctx context.Context, cfg OTLPoverHTTPConfig, extraAtt
 	if len(cfg.Headers) > 0 {
 		opts = append(opts, otlptracehttp.WithHeaders(cfg.Headers))
 	}
+	if cfg.Insecure {
+		opts = append(opts, otlptracehttp.WithInsecure())
+	}
 	opts = append(opts, cfg.Opts...)
 	exp, err = otlptracehttp.New(ctx, opts...)
 	if err != nil {