feat(pci-device): modify host_pci_device tests

Author: mristok

vsphere/data_source_vsphere_host_pci_device_test.go

@@ -6,12 +6,10 @@ package vsphere
 import (
 	"fmt"
 	"os"
-	"regexp"
-	"strconv"
 	"testing"
 
-	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
-	"github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/testhelper"
+	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
+	"github.com/vmware/terraform-provider-vsphere/vsphere/internal/helper/testhelper"
 )
 
 func TestAccDataSourceVSphereHostPciDevice_basic(t *testing.T) {
@@ -25,30 +23,18 @@ func TestAccDataSourceVSphereHostPciDevice_basic(t *testing.T) {
 			{
 				Config: testAccDataSourceVSphereHostPciDeviceConfig(),
 				Check: resource.ComposeTestCheckFunc(
-					resource.TestCheckResourceAttrWith(
+					resource.TestCheckResourceAttrSet(
 						"data.vsphere_host_pci_device.device",
 						"pci_devices.#",
-						func(value string) error {
-							valueInt, err := strconv.Atoi(value)
-							if err != nil {
-								return err
-							}
-
-							if valueInt <= 0 {
-								return fmt.Errorf("number of PCI devices should be greater than 0")
-							}
-							return nil
-						},
 					),
 				),
 			},
 			{
 				Config: testAccDataSourceVSphereHostPciDeviceConfig(),
 				Check: resource.ComposeTestCheckFunc(
-					resource.TestMatchResourceAttr(
+					resource.TestCheckResourceAttrSet(
 						"data.vsphere_host_pci_device.device",
 						"pci_devices.0.name",
-						regexp.MustCompile("(.*?)"),
 					),
 				),
 			},