Replies: 2 comments 1 reply
-
@ashleyryan do you have any thoughts on this? |
Beta Was this translation helpful? Give feedback.
0 replies
-
I would prefer to keep the VisualCheckbox internal for now. For us to export it officially, I would want to add a lot more guardrails to it - probably require something like aria-label like icons do, maybe some sort of aria-selected, and I would prefer not to do that at this time. For the close button, have you looked at the CdsActionButton: https://storybook.core.clarity.design/?path=/story/components-button-action--page |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hi Clarity!
We currently use 2 components from the
internal-components
folder:CdsInternalCloseButton
andCdsInternalVisualCheckbox
:If I remember correctly (@dturcotte could confirm),
CdsInternalVisualCheckbox
was introduced for our team because the regularCdsCheckbox
suffered from performance issues when loaded in a large list, and interaction issues as the click/hover/etc. is handled by the entire row.I don't believe Clarity uses it internally. Is there any particular reason this should stay in the
internal-components
folder instead of making it a first-class citizen?Regarding
CdsInternalCloseButton
, given that v6 now has a whole set of different icon buttons, I think it would make sense to make it a non-internal component as well:I can't speak for other internal components as we currently do not use any (thankfully), but I could see how
Popup
might become something to build more complex components from, when needing a popup-like component that is not achievable through existing Clarity components.What are your thoughts? Thanks again for everything! :)
Beta Was this translation helpful? Give feedback.
All reactions