feat: display TestNG initialization failure

See gradle/gradle#23268

Author: vlsi

plugins/gradle-extensions-plugin/src/main/kotlin/com/github/vlsi/gradle/ThrowablePrinter.kt

@@ -77,6 +77,12 @@ class ThrowablePrinter {
 
         private val defaultHideThrowables =
             listOf<Predicate<Throwable>>(
+                { it.message?.startsWith("Could not complete execution for") == true },
+                {
+                    it is PlaceholderException &&
+                            it.exceptionClassName.endsWith("TestSuiteExecutionException") &&
+                            it.message?.startsWith("Could not complete execution for") == true
+                },
                 { it is LocationAwareException && it.message == it.cause?.message },
                 { it is UncheckedException || it is UncheckedIOException },
                 { it is AssertionError &&
@@ -130,10 +136,11 @@ class ThrowablePrinter {
 
         private val defaultFaintPackages =
             setOf(
-                "java.util.stream.",
+                "java.",
                 "jdk.internal.",
+                "org.gradle.",
                 "org.junit.",
-                "org.gradle."
+                "org.testng."
             )
         private val defaultFrameStyles =
             listOf<(StackTraceElement) -> Style?> {

plugins/gradle-extensions-plugin/src/main/kotlin/com/github/vlsi/gradle/test/dsl/PrintTestResults.kt

@@ -168,6 +168,15 @@ fun Test.printTestResults(
             } else {
                 sb.appendTestName(displayName)
             }
+            if (showStacktrace && result.exceptions.isNotEmpty()) {
+                val throwablePrinter = project.createThrowablePrinter().apply {
+                    indent = "    "
+                }
+                result.exceptions.forEach {
+                    sb.appendPlatformLine()
+                    throwablePrinter.print(it, sb)
+                }
+            }
         }
         println(sb.toString())
     }
@@ -184,7 +193,8 @@ fun Test.printTestResults(
     )
     afterSuite(
         KotlinClosure2<TestDescriptor, TestResult, Any>({ descriptor, result ->
-            if (descriptor.name.startsWith("Gradle Test Executor")) {
+            if (descriptor.name.startsWith("Gradle Test Executor") &&
+                result.exceptions.isEmpty()) {
                 return@KotlinClosure2
             }
             if (result.resultType == TestResult.ResultType.FAILURE ||

plugins/gradle-extensions-plugin/src/test/kotlin/com/github/vlsi/gradle/ErrorReportingTest.kt

@@ -28,25 +28,28 @@ class ErrorReportingTest : BaseGradleTest() {
         private fun gradleVersionAndSettings(): Iterable<Arguments> {
             return mutableListOf<Arguments>().apply {
                 if (JavaVersion.current() <= JavaVersion.VERSION_1_8) {
-                    add(Arguments.of("4.4.1"))
+                    add(Arguments.of("4.9"))
                 }
                 if (JavaVersion.current() <= JavaVersion.VERSION_12) {
                     addAll(
                         listOf(
                             Arguments.of("5.6.2"),
-                            Arguments.of("5.4.1"),
                             Arguments.of("4.10.2")
                         )
                     )
                 }
-                add(Arguments.of("6.0"))
-                add(Arguments.of("6.1.1"))
+                if (JavaVersion.current() < JavaVersion.VERSION_17) {
+                    add(Arguments.of("6.0"))
+                    add(Arguments.of("6.8"))
+                    add(Arguments.of("7.6.1"))
+                }
+                add(Arguments.of("8.0.2"))
             }
         }
     }
 
-    @ParameterizedTest
-    @MethodSource("gradleVersionAndSettings")
+//    @ParameterizedTest
+//    @MethodSource("gradleVersionAndSettings")
     // @ValueSource(strings=["6.1.1"])
     fun `stacktrace is printed`(gradleVersion: String) {
         createSettings()
@@ -76,4 +79,64 @@ class ErrorReportingTest : BaseGradleTest() {
             )
         }
     }
+
+    @ParameterizedTest
+    @MethodSource("gradleVersionAndSettings")
+    fun `testng init failure test`(gradleVersion: String) {
+        createSettings()
+
+        projectDir.resolve("build.gradle").write(
+            /* language=groovy */
+            """
+            plugins {
+              id('com.github.vlsi.gradle-extensions')
+              id('java-library')
+            }
+
+            repositories {
+              mavenCentral()
+            }
+
+            dependencies {
+              testImplementation("org.testng:testng:6.8.1")
+            }
+
+            tasks.test {
+              useTestNG()
+            }
+            """.trimIndent()
+        )
+
+        val dir = projectDir.resolve("src/test/java/com/example")
+        dir.toFile().mkdirs()
+
+        projectDir.resolve("src/test/java/com/example/MyTest.java").write(
+            /* language=java */
+            """
+            package com.example;
+
+            import org.testng.annotations.Test;
+
+            public class MyTest {
+                @Test(dependsOnMethods = {"missingMethod"})
+                public void test() {
+                }
+            }
+            """.trimIndent()
+        )
+
+        val result =
+            prepare(gradleVersion, "test", "-q")
+                .buildAndFail()
+
+        val output = result.output
+        if ("missingMethod" !in output) {
+            Assertions.fail<Any>(
+                """
+                Expecting 'Task :test FAILURE reason:... com.example.MyTest.test() depends on nonexistent method missingMethod:
+                $output
+                """.trimIndent()
+            )
+        }
+    }
 }