-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
[Fix] Fix gemma CI test failing on main #20124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @tdoublep, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a failing CI job related to Gemma model tests. The primary goal is to update an outdated test to be compatible with the current vLLM API, ensuring the continued validation of hybrid SSM/attention models. The changes involve adapting API calls within the test and configuring the environment for proper execution.
Highlights
- Test Fix: Updated the
test_dummy_loader
for Gemma models to align with the latest vLLM API, specifically by adjustingcollective_rpc
calls and accessing model configurations. - Environment Configuration: Introduced a
monkeypatch
to temporarily set theVLLM_ALLOW_INSECURE_SERIALIZATION
environment variable, which is necessary for the updated test to run correctly.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates the Gemma test to align with recent API changes in vLLM. The use of monkeypatch
to set VLLM_ALLOW_INSECURE_SERIALIZATION
is appropriate for this test context, enabling the use of a lambda function with collective_rpc
. The modifications to the collective_rpc
call and attribute access paths for the model engine configuration appear correct and reflect the API refactoring mentioned in the description. The change is straightforward and effectively addresses the failing CI job.
rtol=1e-3) | ||
def test_dummy_loader(vllm_runner, monkeypatch, model: str) -> None: | ||
with monkeypatch.context() as m: | ||
m.setenv("VLLM_ALLOW_INSECURE_SERIALIZATION", "1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wondering why this cause failure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's because you're passing a function into collective_rpc
which can only be serialized via pickle (insecure)
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
Head branch was pushed to by a user without write access
The
This extended generation job is seriously flaky (which I guess is to be expected since it is not running by default). The gemma tests are now passing, so I think this PR can be merged. |
@mgoin @DarkLight1337 @houseroad Could I get a force-merge here? There are two unrelated tests that are failing in the extended generation job due to another issue (see comment here). Looking into that separately, but might as well get these fixes in. |
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com> Signed-off-by: Will Eaton <weaton@redhat.com>
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
Purpose
The optional CI job "Language Models Test (Extended Generation)" is currently failing on main due to one of the Gemma tests that is using out-dated API calls. This PR adapts that failing test to work with latest vLLM API.
This CI job is currently the only one we have that tests hybrid SSM/attention models and so it is pretty useful to have it up and running.
Test Plan
n/a
Test Result
Test is now passing (will trigger it through CI)