Skip to content

Commit c528147

Browse files
committed
[Bugfix][EP+DP] Fix internode check
Signed-off-by: Tyler Michael Smith <tysmith@redhat.com>
1 parent 6865fe0 commit c528147

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

vllm/distributed/device_communicators/all2all.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,6 @@ def _make_all2all_kwargs(self) -> dict[Any, Any]:
178178
num_rdma_bytes = 1024 * 1024 * 1024
179179
num_qps_per_rank = self.num_sms // 2
180180
else:
181-
assert self.intranode
182181
num_rdma_bytes = 0
183182
num_qps_per_rank = 1
184183

@@ -243,7 +242,6 @@ def _make_all2all_kwargs(
243242
if self.internode:
244243
num_rdma_bytes = 1024 * 1024 * 1024
245244
else:
246-
assert self.intranode
247245
num_rdma_bytes = deep_ep.Buffer.get_low_latency_rdma_size_hint(
248246
num_max_dispatch_tokens_per_rank=max_num_tokens_per_dp_rank,
249247
hidden=token_hidden_size,

vllm/distributed/device_communicators/base_device_communicator.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,7 @@ def __init__(self, cpu_group):
4949

5050
# all2all communication often has separate implementations for
5151
# intra-node and inter-node communication
52-
self.intranode = in_the_same_node_as(cpu_group, source_rank=0)
53-
self.internode = not self.intranode
52+
self.internode = not all(in_the_same_node_as(cpu_group, source_rank=0))
5453

5554
def get_handle(self, kwargs):
5655
# get a handle for the all2all communication,

0 commit comments

Comments
 (0)