Skip to content

Commit 042d131

Browse files
authored
Fix links in multi-modal model contributing page (#18615)
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
1 parent 8e807cd commit 042d131

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

docs/contributing/model/multimodal.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -819,7 +819,7 @@ Each [PromptUpdate][vllm.multimodal.processing.PromptUpdate] instance specifies
819819
After you have defined [BaseProcessingInfo][vllm.multimodal.processing.BaseProcessingInfo] (Step 2),
820820
[BaseDummyInputsBuilder][vllm.multimodal.profiling.BaseDummyInputsBuilder] (Step 3),
821821
and [BaseMultiModalProcessor][vllm.multimodal.processing.BaseMultiModalProcessor] (Step 4),
822-
decorate the model class with {meth}`MULTIMODAL_REGISTRY.register_processor <vllm.multimodal.registry.MultiModalRegistry.register_processor>`
822+
decorate the model class with [MULTIMODAL_REGISTRY.register_processor][vllm.multimodal.processing.MultiModalRegistry.register_processor]
823823
to register them to the multi-modal registry:
824824

825825
```diff

vllm/model_executor/models/interfaces.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,11 +89,22 @@ def get_input_embeddings(
8989
) -> Tensor:
9090
...
9191

92+
# TODO: Remove this overload once v0 is deprecated
9293
@overload
9394
def get_input_embeddings(
9495
self,
9596
input_ids: Tensor,
9697
multimodal_embeddings: Optional[MultiModalEmbeddings] = None,
98+
) -> Tensor:
99+
...
100+
101+
def get_input_embeddings(
102+
self,
103+
input_ids: Tensor,
104+
multimodal_embeddings: Optional[MultiModalEmbeddings] = None,
105+
# Only necessary so that the v0 overload is valid
106+
# TODO: Remove attn_metadata once v0 is deprecated
107+
attn_metadata: Optional["AttentionMetadata"] = None,
97108
) -> Tensor:
98109
"""
99110
Returns the input embeddings merged from the text embeddings from

0 commit comments

Comments
 (0)