Skip to content

Commit f6af1d2

Browse files
authored
[MISC] fix logger (#515)
logger in vllm-ascend doesn't work. This PR fix the issue. Fix: #431 Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
1 parent 5c6d796 commit f6af1d2

File tree

9 files changed

+6
-27
lines changed

9 files changed

+6
-27
lines changed

tests/conftest.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,16 +29,13 @@
2929
from vllm.distributed.parallel_state import (destroy_distributed_environment,
3030
destroy_model_parallel)
3131
from vllm.inputs import ExplicitEncoderDecoderPrompt, TextPrompt, TokensPrompt
32-
from vllm.logger import init_logger
3332
from vllm.outputs import RequestOutput
3433
from vllm.sampling_params import BeamSearchParams
3534
from vllm.utils import is_list_of
3635

3736
from tests.model_utils import (TokensTextLogprobs,
3837
TokensTextLogprobsPromptLogprobs)
3938

40-
logger = init_logger(__name__)
41-
4239
_M = TypeVar("_M")
4340

4441
_PromptMultiModalInput = Union[List[_M], List[List[_M]]]

vllm_ascend/platform.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
import torch
2323
import torch_npu # noqa: F401
2424
import vllm.envs as envs
25-
from vllm.logger import init_logger
25+
from vllm.logger import logger
2626

2727
try:
2828
# register custom ops into torch_library here
@@ -48,8 +48,6 @@
4848

4949
os.environ["RAY_EXPERIMENTAL_NOSET_ASCEND_RT_VISIBLE_DEVICES"] = "1"
5050

51-
logger = init_logger(__name__)
52-
5351

5452
class NPUPlatform(Platform):
5553

vllm_ascend/quantization/quant_config.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
import torch
2222
import torch_npu # noqa: F401
2323
from vllm.distributed import get_tensor_model_parallel_rank
24-
from vllm.logger import init_logger
2524
from vllm.model_executor.layers.fused_moe import (FusedMoE, FusedMoEMethodBase,
2625
FusedMoeWeightScaleSupported)
2726
from vllm.model_executor.layers.fused_moe.layer import \
@@ -41,8 +40,6 @@
4140

4241
from .quantizer import AscendQuantizer
4342

44-
logger = init_logger(__name__)
45-
4643

4744
@register_quantization_config("ascend")
4845
class AscendQuantConfig(QuantizationConfig):

vllm_ascend/utils.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,7 @@
1717
# limitations under the License.
1818
#
1919
import torch
20-
from vllm.logger import init_logger
21-
22-
logger = init_logger(__name__)
20+
from vllm.logger import logger
2321

2422

2523
def try_register_lib(lib_name: str, lib_info: str = ""):

vllm_ascend/worker/model_runner.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
from vllm.distributed import get_kv_transfer_group, get_pp_group
3636
from vllm.forward_context import set_forward_context
3737
from vllm.inputs import INPUT_REGISTRY, InputRegistry
38-
from vllm.logger import init_logger
38+
from vllm.logger import logger
3939
from vllm.lora.layers import LoRAMapping
4040
from vllm.lora.request import LoRARequest
4141
from vllm.model_executor import SamplingMetadata, SamplingMetadataCache
@@ -63,8 +63,6 @@
6363
if TYPE_CHECKING:
6464
from vllm.attention.backends.abstract import AttentionBackend
6565

66-
logger = init_logger(__name__)
67-
6866
TModelInputForNPU = TypeVar('TModelInputForNPU', bound="ModelInputForNPU")
6967

7068

vllm_ascend/worker/model_runner_v1.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
from vllm.distributed.parallel_state import get_pp_group
3333
from vllm.forward_context import set_forward_context
3434
from vllm.inputs import INPUT_REGISTRY
35-
from vllm.logger import init_logger
35+
from vllm.logger import logger
3636
from vllm.model_executor.layers.fused_moe import FusedMoE
3737
from vllm.model_executor.model_loader import get_model
3838
from vllm.multimodal import MULTIMODAL_REGISTRY, MultiModalKwargs
@@ -56,8 +56,6 @@
5656

5757
NPU_PAGED_ATTENTION_MASK_VALUE = -10000
5858

59-
logger = init_logger(__name__)
60-
6159

6260
class NPUModelRunner:
6361

vllm_ascend/worker/multi_step_runner.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import torch
88
from torch import nn
99
from vllm.distributed import get_pp_group
10-
from vllm.logger import init_logger
1110
from vllm.model_executor.layers.sampler import (PromptLogprobs, SampleLogprobs,
1211
SamplerOutput,
1312
SamplingMetadata, get_logprobs,
@@ -30,8 +29,6 @@
3029
if TYPE_CHECKING:
3130
from vllm.attention.backends.abstract import AttentionBackend
3231

33-
logger = init_logger(__name__)
34-
3532

3633
@dataclass(frozen=False)
3734
class StatefulModelInputForNPU(StatefulModelInput):

vllm_ascend/worker/worker.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
from vllm.distributed import (ensure_model_parallel_initialized,
2929
init_distributed_environment,
3030
set_custom_all_reduce)
31-
from vllm.logger import init_logger
31+
from vllm.logger import logger
3232
from vllm.lora.request import LoRARequest
3333
from vllm.model_executor import set_random_seed
3434
from vllm.model_executor.layers.sampler import SamplerOutput
@@ -48,8 +48,6 @@
4848
from vllm_ascend.worker.model_runner import NPUModelRunner
4949
from vllm_ascend.worker.pooling_model_runner import NPUPoolingModelRunner
5050

51-
logger = init_logger(__name__)
52-
5351

5452
class NPUWorker(LocalOrDistributedWorkerBase):
5553
"""A worker class that executes (a partition of) the model on a NPU.

vllm_ascend/worker/worker_v1.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
from vllm.distributed import (ensure_model_parallel_initialized,
3030
init_distributed_environment,
3131
set_custom_all_reduce)
32-
from vllm.logger import init_logger
32+
from vllm.logger import logger
3333
from vllm.model_executor import set_random_seed
3434
from vllm.platforms import current_platform
3535
from vllm.utils import STR_DTYPE_TO_TORCH_DTYPE
@@ -42,8 +42,6 @@
4242

4343
from vllm_ascend.worker.model_runner_v1 import NPUModelRunner
4444

45-
logger = init_logger(__name__)
46-
4745

4846
class NPUWorker(WorkerBase):
4947

0 commit comments

Comments
 (0)