Skip to content

Commit a95afc0

Browse files
authored
[CI] Enable merge trigger unit test and accuracy test schedule job (#1345)
### What this PR does / why we need it? - Enable merge trigger unit test and accuracy test schedule job - Pin lm-eval==0.4.8 to resovle Qwen3 8B accuracy ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
1 parent 2e5f312 commit a95afc0

File tree

4 files changed

+19
-9
lines changed

4 files changed

+19
-9
lines changed

.github/workflows/accuracy_test.yaml

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@
2222
name: Benchmarks / accuracy
2323

2424
on:
25+
schedule:
26+
# Runs every 6 hours
27+
- cron: '0 */6 * * *'
2528
pull_request:
2629
types: [ labeled ]
2730
workflow_dispatch:
@@ -43,6 +46,7 @@ on:
4346
options:
4447
- main
4548
- v0.7.3-dev
49+
- v0.9.1-dev
4650
models:
4751
description: 'model:'
4852
required: true
@@ -75,7 +79,7 @@ jobs:
7579
contains(github.event.pull_request.labels.*.name, 'vl-accuracy-test') ||
7680
contains(github.event.pull_request.labels.*.name, 'dense-accuracy-test')) &&
7781
contains(github.event.pull_request.labels.*.name, 'ready-for-test') ||
78-
github.event_name == 'workflow_dispatch'
82+
github.event_name == 'workflow_dispatch' || github.event_name == 'schedule'
7983
}}
8084
runs-on: >-
8185
${{
@@ -94,6 +98,8 @@ jobs:
9498
# - dense-accuracy-test: Qwen/Qwen2.5-7B-Instruct
9599
# - vl-accuracy-test: Qwen/Qwen2.5-VL-7B-Instruct
96100
model_name: ${{ fromJSON(
101+
(github.event_name == 'schedule' &&
102+
'["Qwen/Qwen2.5-7B-Instruct","Qwen/Qwen2.5-VL-7B-Instruct","Qwen/Qwen3-8B-Base"]') ||
97103
(github.event.inputs.models == 'all' &&
98104
'["Qwen/Qwen2.5-7B-Instruct","Qwen/Qwen2.5-VL-7B-Instruct","Qwen/Qwen3-8B-Base"]') ||
99105
(github.event.inputs.models == 'Qwen/Qwen2.5-7B-Instruct' &&
@@ -103,9 +109,9 @@ jobs:
103109
(github.event.inputs.models == 'Qwen/Qwen3-8B-Base' &&
104110
'["Qwen/Qwen3-8B-Base"]') ||
105111
contains(github.event.pull_request.labels.*.name, 'accuracy-test') &&
106-
'["Qwen/Qwen2.5-7B-Instruct","Qwen/Qwen2.5-VL-7B-Instruct"]' ||
112+
'["Qwen/Qwen3-8B-Base","Qwen/Qwen2.5-VL-7B-Instruct"]' ||
107113
contains(github.event.pull_request.labels.*.name, 'dense-accuracy-test') &&
108-
'["Qwen/Qwen2.5-7B-Instruct"]' ||
114+
'["Qwen/Qwen3-8B-Base"]' ||
109115
contains(github.event.pull_request.labels.*.name, 'vl-accuracy-test') &&
110116
'["Qwen/Qwen2.5-VL-7B-Instruct"]'
111117
) }}
@@ -181,7 +187,7 @@ jobs:
181187
182188
- name: Install lm-eval, ray, and datasets
183189
run: |
184-
pip install lm-eval
190+
pip install lm-eval==0.4.8
185191
186192
- name: Collect version info
187193
run: |

.github/workflows/image_310p_openeuler.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: 'image / openEuler'
1+
name: 'image / openEuler / 310p'
22
# This is a docker build check and publish job:
33
# 1. PR Triggered docker image build check
44
# - is for image build check

.github/workflows/image_310p_ubuntu.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: 'image / Ubuntu'
1+
name: 'image / Ubuntu / 310p'
22
# This is a docker build check and publish job:
33
# 1. PR Triggered docker image build check
44
# - is for image build check
@@ -16,7 +16,7 @@ on:
1616
- 'main'
1717
- '*-dev'
1818
paths:
19-
- '.github/workflows/image_310p.ubuntu.yml'
19+
- '.github/workflows/image_310p_ubuntu.yml'
2020
- 'Dockerfile.310p'
2121
- 'vllm_ascend/**'
2222
- 'setup.py'

.github/workflows/vllm_ascend_test.yaml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,8 @@ concurrency:
6666

6767
jobs:
6868
lint:
69+
# Only trigger lint on pull request
70+
if: ${{ github.event_name == 'pull_request' }}
6971
runs-on: ubuntu-latest
7072
strategy:
7173
matrix:
@@ -131,7 +133,8 @@ jobs:
131133
ut:
132134
needs: [lint]
133135
name: unit test
134-
if: ${{ needs.lint.result == 'success' }}
136+
# only trigger e2e test on [pull request after lint passed] and [merged commit]
137+
if: ${{ needs.lint.result == 'success' || github.event_name == 'push' }}
135138
runs-on: ubuntu-latest
136139
container:
137140
image: m.daocloud.io/quay.io/ascend/cann:8.1.rc1-910b-ubuntu22.04-py3.10
@@ -191,7 +194,8 @@ jobs:
191194

192195
e2e:
193196
needs: [lint]
194-
if: ${{ needs.lint.result == 'success' }}
197+
# only trigger e2e test on pull request after lint passed
198+
if: ${{ needs.lint.result == 'success' && github.event_name == 'pull_request' }}
195199
strategy:
196200
max-parallel: 2
197201
matrix:

0 commit comments

Comments
 (0)